Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.8] VMware: remove duplicate implementation of memory reservation #56205

Merged
merged 1 commit into from May 21, 2019

Conversation

Projects
None yet
4 participants
@Akasurde
Copy link
Member

commented May 8, 2019

SUMMARY

mem_reservation and memory_reservation has redundant implementation.
Combining them together.

Fixes: #54335

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com
(cherry picked from commit 193f690)

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

changelogs/fragments/54335-vmware_guest-memory_reservation.yml
lib/ansible/modules/cloud/vmware/vmware_guest.py

[2.8] VMware: remove duplicate implementation of memory reservation
mem_reservation and memory_reservation has redundant implementation.
Combining them together.

Fixes: #54335

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 193f690)
@ansibot

This comment has been minimized.

@pdellaert
Copy link
Contributor

left a comment

LGTM

@abadger abadger merged commit 0cfc338 into ansible:stable-2.8 May 21, 2019

1 check passed

Shippable Run 123182 status is SUCCESS.
Details
@abadger

This comment has been minimized.

Copy link
Member

commented May 21, 2019

Merged for the 2.8.1 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.