Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nxos_acl: some platforms/versions raise when no ACLs are present (#55609) #56214

Merged
merged 1 commit into from May 21, 2019

Conversation

Projects
None yet
4 participants
@trishnaguha
Copy link
Member

commented May 8, 2019

nxos_acl: some platforms/versions raise when no ACLs are present (#55609)

  • nxos_acl may fail with IndexError: list index out of range while attempting to delete a non-existent ACL.

The failure occurs when the acl var is an empty list.

  • nxos_acl: catch 501 'Structured output unsupported' when no ACLs present

With some older image versions, show ip access-list | json will raise a 501 error indicating 'Structured output unsupported' when there are no access-lists configured. This change turns off the check_rc and then looks for the failure condition.

  • Fix kwarg

  • Fix lint issues

(cherry picked from commit 869fdcd)

SUMMARY
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

nxos_acl: some platforms/versions raise when no ACLs are present (#55609
)

* `nxos_acl` may fail with `IndexError: list index out of range` while attempting to delete a non-existent ACL.

The failure occurs when the `acl` var is an empty list.

* nxos_acl: catch 501 'Structured output unsupported' when no ACLs present

With some older image versions, `show ip access-list | json` will raise a 501 error indicating `'Structured output unsupported'` when there are no access-lists configured. This change turns off the `check_rc` and then looks for the failure condition.

* Fix kwarg

* Fix lint issues

(cherry picked from commit 869fdcd)
@ansibot

This comment has been minimized.

@ansibot ansibot added the stale_ci label May 16, 2019

@abadger abadger merged commit a85461e into ansible:stable-2.8 May 21, 2019

1 check passed

Shippable Run 122149 status is SUCCESS.
Details
@abadger

This comment has been minimized.

Copy link
Member

commented May 21, 2019

Merged for the 2.8.1 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.