Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rds_instance module… #56220

Open
wants to merge 4 commits into
base: devel
from

Conversation

Projects
None yet
3 participants
@stefanhorning
Copy link
Contributor

commented May 8, 2019

SUMMARY

… to run against an existing RDS instance successfully

Fixes tow issues I experienced when trying to run this module against an already existing RDS instance (created 2016). See details below.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

rds_instance module

ADDITIONAL INFORMATION

Fixes two errors (relevant exception snippets):

  1. [...] line 903, in get_current_attributes_with_inconsistent_keys KeyError: 'PerformanceInsightsEnabled' [...]
  2. [...] line 948, in get_changing_options_with_consistent_keys KeyError: 'Iops' [...]

stefanhorning added some commits May 8, 2019

Only pop Iops param if no storage_type is given. If given and set to …
…wrong type we get to the AWS client error that informs the user
@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 8, 2019

Fix typo in docs
Co-Authored-By: stefanhorning <stefan@hornings.de>

@ansibot ansibot added the stale_ci label May 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.