Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure uri module always returns status even on failure #56240

Open
wants to merge 4 commits into
base: devel
from

Conversation

Projects
None yet
4 participants
@samdoran
Copy link
Member

commented May 8, 2019

SUMMARY

Fixes #55897

Also return url and update docs for other values to indicate they are only returned on success.
Add integration tests

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/module_utils/urls.py

ADDITIONAL INFORMATION

This seems a bit "leaky" in that I have to change the behavior of urls.py to make uri.py behave as documented. If this fix seems ok. I will also add unit tests.

Ensure uri module always returns status even on failure
Also return url and update docs for other values to indicate they are only returned on success.

Add integration tests

@samdoran samdoran requested a review from sivel May 8, 2019

@samdoran samdoran changed the title [WIP] Ensure uri module always returns status even on failure Ensure uri module always returns status even on failure May 9, 2019

@ansibot ansibot added needs_revision and removed WIP labels May 11, 2019

@jillr jillr removed the needs_triage label May 16, 2019

@ansibot ansibot added the stale_ci label May 19, 2019

samdoran added some commits May 9, 2019

Use -1 as default status rather than None
This is lines up with with existing code in urls.py

@samdoran samdoran force-pushed the samdoran:issue/55897-uri-invalid-cert-status branch from 3e0d377 to 863dbf2 May 20, 2019

@samdoran samdoran requested review from sivel and removed request for sivel May 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.