Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport/2.8/55695 #56254

Merged
merged 3 commits into from May 21, 2019

Conversation

Projects
None yet
3 participants
@kustodian
Copy link
Contributor

commented May 9, 2019

SUMMARY

Backport of #55695

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

sysctl

kustodian added some commits Apr 24, 2019

sysctl will now return an error if the value is invalid
sysctl can fail to set a value even if it returns an exit status 0. More
details: https://bugzilla.redhat.com/show_bug.cgi?id=1264080. Because of
this in case of an invalid value or a read-only file system, sysctl
module would return OK, even though it didn't set anything. To be sure
that sysctl correctly applied the changes we also need to check the
output of stderr.

(cherry picked from commit 0432b7f)
Run sysctl with LANG=C
Because we are parsing sysctl stderr we need to make sure that errors
are persistent across different system language settings.

(cherry picked from commit a16128f)
Add changelog fragment for sysctl
(cherry picked from commit 3ad9d4d)
@kustodian

This comment has been minimized.

Copy link
Contributor Author

commented May 9, 2019

@samdoran here is a backport of #55695

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 9, 2019

@ansibot ansibot added the stale_ci label May 17, 2019

@abadger abadger merged commit cf611c8 into ansible:stable-2.8 May 21, 2019

1 check passed

Shippable Run 122249 status is SUCCESS.
Details
@abadger

This comment has been minimized.

Copy link
Member

commented May 21, 2019

Merged for the 2.8.1 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.