Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.7] connection/docker: add privilege escalation support #56278

Merged
merged 1 commit into from May 21, 2019

Conversation

Projects
None yet
4 participants
@larsks
Copy link
Contributor

commented May 9, 2019

SUMMARY

Backport of #55816 to stable-2.7. Fixes privilege escalation for docker connection plugin if a passphrase is required.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/plugins/connection/docker.py

Show resolved Hide resolved lib/ansible/plugins/connection/docker.py Outdated
Show resolved Hide resolved lib/ansible/plugins/connection/docker.py Outdated

@ansibot ansibot removed the needs_triage label May 9, 2019

connection/docker: add privilege escalation support
As described in #53385 (and #31759), the docker connection driver did
not support privilege escalation. This commit is a shameless
cut-and-paste of the privilege escalation support from the `local`
connection plugin into the `docker` plugin.

This is a backport to stable-2.7 of #55816.

@larsks larsks force-pushed the larsks:backport/2.7/55816 branch from 27f1d09 to b591de7 May 10, 2019

@felixfontein
Copy link
Contributor

left a comment

LGTM

@ansibot ansibot added shipit and removed community_review labels May 12, 2019

@abadger abadger merged commit a8e14cf into ansible:stable-2.7 May 21, 2019

1 check passed

Shippable Run 123543 status is SUCCESS.
Details
@abadger

This comment has been minimized.

Copy link
Member

commented May 21, 2019

Merged for 2.7.11

@felixfontein

This comment has been minimized.

Copy link
Contributor

commented May 21, 2019

@larsks thanks for creating the backport!
@abadger thanks for merging this and all the others!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.