Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #54550 #56279

Open
wants to merge 3 commits into
base: devel
from

Conversation

Projects
None yet
4 participants
@ShachafGoldstein
Copy link
Contributor

commented May 9, 2019

SUMMARY

Fixes #54550

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

setup.ps1

ADDITIONAL INFORMATION
@ansibot

This comment has been minimized.

"setup.ps1" - Change $env:COMPUTERNAME to [System.Net.Dns]::GetHostNa…
…me(), to support non NETBIOS compliant hostnames

@ShachafGoldstein ShachafGoldstein force-pushed the ShachafGoldstein:54550 branch from f425038 to 19f408e May 9, 2019

@jhawkesworth

This comment has been minimized.

Copy link
Contributor

commented May 14, 2019

Not tested but this seems like a good change to have to me.
Would be nice to perhaps change the win_hostname module and tests for win_hostname (test/integration/targets/win_hostname/tasks/ ) module to exercise this and ensure non-netbios hostnames are managed there as well (probably best as a separate PR).

@ansibot ansibot removed the needs_triage label May 14, 2019

@ShachafGoldstein

This comment has been minimized.

Copy link
Contributor Author

commented May 14, 2019

Not tested but this seems like a good change to have to me.
Would be nice to perhaps change the win_hostname module and tests for win_hostname (test/integration/targets/win_hostname/tasks/ ) module to exercise this and ensure non-netbios hostnames are managed there as well (probably best as a separate PR).

There is a separate issue regarding win_hostname and netbios names, ill tackle that one soon and ill add the mentioned tests there (#55283)

@ShachafGoldstein

This comment has been minimized.

Copy link
Contributor Author

commented May 14, 2019

Change to use Win32_ComputerSystem and add ansible_netbios_name, check for name dependency like fqdn facts

Show resolved Hide resolved lib/ansible/modules/windows/setup.ps1 Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.