Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker connection plugin: make privilege escalation code more similar to local.py #56288

Merged
merged 2 commits into from May 19, 2019

Conversation

Projects
None yet
4 participants
@felixfontein
Copy link
Contributor

commented May 10, 2019

SUMMARY

Extends #55816.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/plugins/connection/docker.py

@felixfontein

This comment has been minimized.

Copy link
Contributor Author

commented May 10, 2019

CC @larsks

@ansibot

This comment has been minimized.

@larsks

larsks approved these changes May 16, 2019

Copy link
Contributor

left a comment

LGTM.

@felixfontein

This comment has been minimized.

Copy link
Contributor Author

commented May 19, 2019

shipit

@ansibot ansibot merged commit 708bda0 into ansible:devel May 19, 2019

1 check passed

Shippable Run 123506 status is SUCCESS.
Details

felixfontein added a commit to felixfontein/ansible that referenced this pull request May 19, 2019

docker connection plugin: make privilege escalation code more similar…
… to local.py (ansible#56288)

* Make more similar to local.py

* Fix typo.

(cherry picked from commit 708bda0)

@sivel sivel removed the needs_triage label May 20, 2019

abadger added a commit that referenced this pull request May 21, 2019

[WIP] [2.8] connection/docker: add support for privilege escalation (#…
…56277)

* connection/docker: add privilege escalation support (#55816)

As described in #53385 (and #31759), the docker connection driver did
not support privilege escalation. This commit is a shameless
cut-and-paste of the privilege escalation support from the `local`
connection plugin into the `docker` plugin.

Closes: #53385
(cherry picked from commit 61e476b)

* docker connection plugin: make privilege escalation code more similar to local.py (#56288)

* Make more similar to local.py

* Fix typo.

(cherry picked from commit 708bda0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.