Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nxos_snmp_user: platform fixes for get_snmp_user (#55832) #56291

Merged
merged 1 commit into from May 21, 2019

Conversation

Projects
None yet
4 participants
@trishnaguha
Copy link
Member

commented May 10, 2019

SUMMARY
  • nxos_snmp_user: platform fixes for get_snmp_user

snmp user output behavior varies quite a bit for the different nxos platforms and required several workarounds:

  • N5K/N6k

  • These platforms do not support structured output for show snmp user.

  • The current code lands in an except clause when the output is not structured; so I added a new get_non_structured_snmp_user method to scrape the state from the regular cli output if it's present.

  • N9K-F

  • The group data in the JSON output is different for this platform; it has a different key (just group instead of TABLE_groups or group_names) and it is not indexed

  • For a single group the value is a string, for multiple groups it's a list

  • sanity

  • N5K/N6K/N9K-F platforms will reject no snmp user <name> <role> when it's the last role defined for the user.

  • workaround is to use nxos_user to remove the user

  • Changes validated on:

  • N3K, N3K-F, N35, N6K, N7K, N9K, N9K-F

  • 6.0(2)A8

  • 7.0(3)I2, 7.0(3)I4, 7.0(3)I5, 7.0(3)I6, 7.0(3)I7

  • 7.3(2)D1

  • 7.3(3)N1, 7.3(4)N1

  • 8.3(2)

  • 9.2(2), 9.2(3)

  • fix lint warning

(cherry picked from commit 8c56c11)

ISSUE TYPE
  • Bugfix Pull Request
nxos_snmp_user: platform fixes for get_snmp_user (#55832)
* nxos_snmp_user: platform fixes for get_snmp_user

snmp user output behavior varies quite a bit for the different nxos platforms and required several workarounds:

- N5K/N6k
 - These platforms do not support structured output for `show snmp user`.
 - The current code lands in an `except` clause when the output is not structured; so I added a new `get_non_structured_snmp_user` method to scrape the state from the regular cli output if it's present.

- N9K-F
 - The `group` data in the JSON output is different for this platform; it has a different key (just `group` instead of `TABLE_groups` or `group_names`) and it is not indexed
 - For a single group the value is a string, for multiple groups it's a list

- sanity
 - N5K/N6K/N9K-F platforms will reject `no snmp user <name> <role>` when it's the last role defined for the user.
 - workaround is to use `nxos_user` to remove the user

- Changes validated on:
 - `N3K, N3K-F, N35, N6K, N7K, N9K, N9K-F`
 - `6.0(2)A8`
 - `7.0(3)I2, 7.0(3)I4, 7.0(3)I5, 7.0(3)I6, 7.0(3)I7`
 - `7.3(2)D1`
 - `7.3(3)N1, 7.3(4)N1`
 - `8.3(2)`
 - `9.2(2), 9.2(3)`

* fix lint warning

(cherry picked from commit 8c56c11)
@ansibot

This comment has been minimized.

@ansibot ansibot added the stale_ci label May 19, 2019

@abadger abadger merged commit bf8a838 into ansible:stable-2.8 May 21, 2019

1 check passed

Shippable Run 122389 status is SUCCESS.
Details
@abadger

This comment has been minimized.

Copy link
Member

commented May 21, 2019

Merged for the 2.8.1 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.