Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Drop tox.ini for ansible-test to 1.4.2 #56309

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
4 participants
@pabelanger
Copy link
Contributor

commented May 10, 2019

SUMMARY

Lower the tox requirement to 1.4.2 so we can run against centos-7. This is the default version of tox that ships with centos-7.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ansible-test

ADDITIONAL INFORMATION

This is for python2.7 testing using centos-7 as controller.

Drop tox.ini for ansible-test to 1.4.2
This is so we can run ansible-test via tox, under default version of tox
that ships with centos-7.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>

@pabelanger pabelanger changed the title Drop tox.ini for ansible-test to 1.4.2 WIP: Drop tox.ini for ansible-test to 1.4.2 May 10, 2019

pabelanger added a commit to pabelanger/ansible-zuul-jobs-1 that referenced this pull request May 10, 2019

Refactor ansible-test-network-integration-vyos
This adds both python27 and python37 support for testing vyos.

Depends-On: ansible/ansible#56309
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
@@ -1,6 +1,6 @@
[tox]
skipsdist = True
minversion = 2.5.0
minversion = 1.4.2

This comment has been minimized.

Copy link
@mattclay

mattclay May 10, 2019

Member

This will pass CI since we're not using the --tox option there, but it won't work right.

We need changes made in version 2.5.0 of tox, specifically:

slightly backward incompatible: fix #310: the {posargs} substitution now properly preserves the tox command line positional arguments. Positional arguments with spaces are now properly handled. NOTE: if your tox invocation previously used extra quoting for positional arguments to work around #310, you need to remove the quoting. Example: tox – “‘some string’” # has to now be written simply as tox – “some string” thanks holger krekel. You can set minversion = 2.5.0 in the [tox] section of tox.ini to make sure people using your tox.ini use the correct version.

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.