Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR for fixing NIOS_ZONE module idempotency #56347

Merged
merged 2 commits into from May 21, 2019
Merged
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

Next

To fix the issue where nios_zone module was running second time for s…

…ame object (#55595)

* fix for 55128 issue

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* review comment fix

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
(cherry picked from commit 661f7be)
  • Loading branch information...
justjais committed May 13, 2019
commit a41884439c6f23c23775a764908ab5762b3c7b1a
@@ -447,8 +447,8 @@ def get_object_ref(self, module, ib_obj_type, obj_filter, ib_spec):
temp = ib_spec['restart_if_needed']
del ib_spec['restart_if_needed']
ib_obj = self.get_object(ib_obj_type, obj_filter.copy(), return_fields=ib_spec.keys())
# reinstate restart_if_needed key if it's set to true in play
if module.params['restart_if_needed']:
# reinstate restart_if_needed if ib_obj is none, meaning there's no existing nios_zone ref
if not ib_obj:
ib_spec['restart_if_needed'] = temp
elif (ib_obj_type == NIOS_MEMBER):
# del key 'create_token' as nios_member get_object fails with the key present
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.