Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure_rm_azurefirewall #56359

Merged
merged 7 commits into from May 20, 2019

Conversation

Projects
None yet
3 participants
@zikalino
Copy link
Contributor

commented May 13, 2019

SUMMARY

Support for Azure Firewall

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

azure_rm_azurefirewall

ADDITIONAL INFORMATION
@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 13, 2019

@Madhura-CSI @brusMX @caohai @cperrin88 @devigned @gustavomcarmo @haroldwongms @iphilpot @julienstroheker @lmazuel @obsoleted @sozercan @techknowlogick @trstringer @yaweiw @yuwzho

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@ansibot

This comment has been minimized.

zikalino added some commits May 15, 2019

@nitzmahone
Copy link
Member

left a comment

Looks great! The module impl is super simple for such a complex resource...

The only minor question/change I have is why the rule priority values are string-typed in all the samples- seems like they should be type: int in the argspec/docs since the underlying REST API wants int...

zikalino added some commits May 15, 2019

@zikalino

This comment has been minimized.

Copy link
Contributor Author

commented May 16, 2019

@nitzmahone addressed the comment. is this one ok to merge?

@nitzmahone nitzmahone merged commit b37ae35 into ansible:devel May 20, 2019

1 check passed

Shippable Run 123085 status is SUCCESS.
Details

@zikalino zikalino deleted the VSChina:new-azure-firewall branch May 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.