Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport/2.8/56357 #56367

Merged
merged 2 commits into from May 21, 2019

Conversation

Projects
None yet
4 participants
@tzurE
Copy link
Contributor

commented May 13, 2019

SUMMARY

ibm_storage utils module fix for a bug where null args were being passed. This caused a failure in most of our modules.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ibm_sa_utils

ADDITIONAL INFORMATION
ansible 2.8.0rc3.post0
  config file = None
  configured module search path = [u'/Users/tzure/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/tzure/git/ansible/lib/ansible
  executable location = /Users/tzure/git/ansible/bin/ansible
  python version = 2.7.10 (default, Aug 17 2018, 19:45:58) [GCC 4.2.1 Compatible Apple LLVM 10.0.0 (clang-1000.0.42)]

tzurE added some commits May 13, 2019

IBM_Storage: fixed a bug which caused several of our modules to pass …
…unwanted arguments and fail

(cherry picked from commit 13f5cf4)
IBM_Storage: Added a changelog for 56357 bug
(cherry picked from commit 0de770e)
@alonm

This comment has been minimized.

Copy link

commented May 13, 2019

Without this fix we have several operations that will fail

@@ -0,0 +1,2 @@
bugfixes:
- ibm_storage - Added a check for null fields in ibm_storage utils module.

This comment has been minimized.

Copy link
@abadger

abadger May 21, 2019

Member

Note, it's better if changelogs reflect what was changed from the POV of the user. For instance, fixed a traceback when storage options were unset in the initial configuration. (I don't know if that's actually what is happening here, it's just an example ;-)

@abadger abadger merged commit 51fb908 into ansible:stable-2.8 May 21, 2019

1 check passed

Shippable Run 122630 status is SUCCESS.
Details
@abadger

This comment has been minimized.

Copy link
Member

commented May 21, 2019

Merged for the 2.8.1 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.