Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport/2.8/56357 #56367

merged 2 commits into from May 21, 2019
Changes from all commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.


Just for now

@@ -0,0 +1,2 @@
- ibm_storage - Added a check for null fields in ibm_storage utils module.

This comment has been minimized.

Copy link

abadger May 21, 2019


Note, it's better if changelogs reflect what was changed from the POV of the user. For instance, fixed a traceback when storage options were unset in the initial configuration. (I don't know if that's actually what is happening here, it's just an example ;-)

@@ -81,6 +81,8 @@ def build_pyxcli_command(fields):
""" Builds the args for pyxcli using the exact args from ansible"""
pyxcli_args = {}
for field in fields:
if not fields[field]:
if field in AVAILABLE_PYXCLI_FIELDS and fields[field] != '':
pyxcli_args[field] = fields[field]
return pyxcli_args
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.