Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport 2.7] Expose timeout option to Redfish modules (#54130) #56377

Merged
merged 1 commit into from May 21, 2019

Conversation

Projects
None yet
5 participants
@jyundt
Copy link
Contributor

commented May 14, 2019

(cherry picked from commit d8536e4)

SUMMARY

Backport request of #54130 to 2.7. This PR fixes #52332 which addresses timeouts that occur when a Redfish response takes longer than the default 10 second open_url() timeout.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

redfish_utils
redfish_facts
redfish_config
redfish_command

ADDITIONAL INFORMATION

I wasn't sure what was appropriate for the version_added fields for this timeout option. I guessed at 2.7.11 but can change (or omit) this.

(venv) [jyundt@donuc ansible]$ ansible --version
ansible 2.7.10.post0 (backport/2.7/54130 bcb2b2827a) last updated 2019/05/13 19:56:15 (GMT -400)
  config file = None
  configured module search path = [u'/home/jyundt/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /home/jyundt/git/ansible/lib/ansible
  executable location = /home/jyundt/git/ansible/bin/ansible
  python version = 2.7.5 (default, Apr  9 2019, 14:30:50) [GCC 4.8.5 20150623 (Red Hat 4.8.5-36)]
(venv) [jyundt@donuc ansible]$ 

cc @nlopez @jose-delarosa

Expose timeout option to Redfish modules
(cherry picked from commit d8536e4)
@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 14, 2019

@billdodd
Copy link
Contributor

left a comment

I reviewed this backport. Changes look good.

shipit

@ansibot ansibot removed the needs_triage label May 16, 2019

@mraineri

This comment has been minimized.

Copy link

commented May 16, 2019

shipit

@ansibot ansibot added shipit and removed community_review labels May 16, 2019

@abadger

This comment has been minimized.

Copy link
Member

commented May 21, 2019

This is a new feature which is usually not eligible for backporting. I understand that it leaves users with an unresolvable problem due to timeouts being exceeded if it's not settable by them, though.... I'll go ahead and merge but these sorts of backports probably should be evaluated by more people rather than just being up to the release manager the Monday before the release.

Next time, please put it onto a meeting agenda and get it discussed and evaluated by the core team. Thanks!

@abadger abadger merged commit 6164387 into ansible:stable-2.7 May 21, 2019

1 check passed

Shippable Run 122660 status is SUCCESS.
Details
@abadger

This comment has been minimized.

Copy link
Member

commented May 21, 2019

Merged for the 2.7.11 release.

@jyundt jyundt deleted the jyundt:backport/2.7/54130 branch May 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.