Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg5: wrap 'to modify' package list #56378

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
3 participants
@github-kjsj
Copy link

commented May 14, 2019

SUMMARY

When executing against an OmniOS (r151030) node with only the Python 3.5.7 package installed, pkg5 module tasks fail due to differing behavior between Python 2.x and 3.x (if the Python 2 package is present, /usr/bin/python defaults to that, and everything works as expected). Wrapping filter() with a list() should cover both 2.x and 3.x.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

pkg5

ADDITIONAL INFORMATION

The trace returned when the module fails:

Traceback (most recent call last):
File "", line 113, in
File "", line 105, in _ansiballz_main
File "", line 48, in invoke_module
File "/usr/lib/python3.5/imp.py", line 235, in load_module
return load_source(name, filename, file)
File "/usr/lib/python3.5/imp.py", line 170, in load_source
module = _exec(spec, sys.modules[name])
File "", line 626, in _exec
File "", line 697, in exec_module
File "", line 222, in _call_with_frames_removed
File "/tmp/ansible_pkg5_payload_lw9t_kg5/main.py", line 154, in
File "/tmp/ansible_pkg5_payload_lw9t_kg5/main.py", line 88, in main
File "/tmp/ansible_pkg5_payload_lw9t_kg5/main.py", line 129, in ensure
TypeError: can only concatenate list (not "filter") to list

@ansibot

This comment has been minimized.

@mavit

This comment has been minimized.

Copy link
Contributor

commented May 14, 2019

LGTM

@ansibot ansibot removed the needs_triage label May 14, 2019

@ansibot ansibot added the stale_ci label May 22, 2019

@github-kjsj

This comment has been minimized.

Copy link
Author

commented May 24, 2019

bot_status

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 24, 2019

Components

lib/ansible/modules/packaging/os/pkg5.py
support: community
maintainers: bcoca dagwieers fishman jasperla jpdasma mator mavit scathatheworm troy2914 xen0l

Metadata

waiting_on: maintainer
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 1
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 0
shipit_actors (maintainers or core team members): mavit
shipit_actors_other: []
automerge: automerge shipit test failed

click here for bot help

@github-kjsj

This comment has been minimized.

Copy link
Author

commented May 24, 2019

ready_for_review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.