Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Galaxy install warning should include the version of the dependency so we can better understand the problem #56379

Merged
merged 1 commit into from May 21, 2019

Conversation

Projects
None yet
4 participants
@jonpugh
Copy link
Contributor

commented May 14, 2019

SUMMARY

When I get messages like this, I'm still not sure what is going on! I get it all the time. The role versions are up to date...

Put aside the confusion as to why this is happening, I saw a chance to improve the error message.

 [WARNING]: - dependency geerlingguy.php from role geerlingguy.php-mysql differs from already installed version
(3.7.0), skipping

There's a bit of information here that isn't being displayed.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

galaxy cli

ADDITIONAL INFORMATION

To reproduce:

roles.yml

- name: geerlingguy.php
  version: 3.7.0

- name: geerlingguy.php-mysql
  version: 2.0.2
$ ansible-galaxy install -r roles.yml
- downloading role 'php', owned by geerlingguy
- downloading role from https://github.com/geerlingguy/ansible-role-php/archive/3.7.0.tar.gz
- extracting geerlingguy.php to /home/jon/Projects/devshop/deps/geerlingguy.php
- geerlingguy.php (3.7.0) was installed successfully
- downloading role 'php-mysql', owned by geerlingguy
- downloading role from https://github.com/geerlingguy/ansible-role-php-mysql/archive/2.0.2.tar.gz
- extracting geerlingguy.php-mysql to /home/jon/Projects/devshop/deps/geerlingguy.php-mysql
- geerlingguy.php-mysql (2.0.2) was installed successfully
 [WARNING]: - dependency geerlingguy.php from role geerlingguy.php-mysql differs from already installed version
(3.7.0), skipping

What's really happening is that geerlingguy.php is required geerlingguy.php-mysql already, so adding it to the playbook is redundant, but I think it's useful to keep it in the playbook because it pins the version, and Galaxy roles can't declare dependency to specific versions.

@samdoran samdoran removed the needs_triage label May 21, 2019

@bcoca bcoca merged commit 7f5b1e9 into ansible:devel May 21, 2019

1 check passed

Shippable Run 122662 status is SUCCESS.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.