Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Scaleway lb backend #56386

Open
wants to merge 2 commits into
base: devel
from

Conversation

Projects
None yet
3 participants
@remyleone
Copy link
Contributor

commented May 14, 2019

SUMMARY

This PR adds a scaleway_lb_backend module. The goal of this module is to configure backend rules of a given scaleway load balancer.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME
  • scaleway_lb_backend
@ansibot

This comment has been minimized.

@remyleone remyleone force-pushed the remyleone:scaleway_lb_backend branch from b8dc3ca to b405124 May 14, 2019

@ansibot ansibot removed the support:core label May 14, 2019


# New convention about region naming
SCALEWAY_NEW_LOCATION = {
'fr-par': {'name': 'Paris 1', 'country': 'FR', "api_endpoint": 'https://api-world.scaleway.com'},

This comment has been minimized.

Copy link
@QuentinBrosse

QuentinBrosse May 15, 2019

https://api.scaleway.com (without world)

# New convention about region naming
SCALEWAY_NEW_LOCATION = {
'fr-par': {'name': 'Paris 1', 'country': 'FR', "api_endpoint": 'https://api-world.scaleway.com'},
'nl-ams': {'name': 'Amsterdam 1', 'country': 'NL', "api_endpoint": 'https://api-world.scaleway.com'}

This comment has been minimized.

Copy link
@QuentinBrosse

QuentinBrosse May 15, 2019

https://api.scaleway.com (without world)

state=dict(choices=state_strategy.keys(), default='present'),
tags=dict(type="list", default=[]),
region=dict(required=True, choices=SCALEWAY_NEW_LOCATION.keys()),

This comment has been minimized.

Copy link
@QuentinBrosse
forward_port=dict(required=True, type='int'),
forward_protocol=dict(choices=["http", "tcp"], default="tcp"),
forward_port_algorithm=dict(choices=["roundrobin", "leastconn"], default="roundrobin"),
region=dict(required=True, choices=SCALEWAY_NEW_LOCATION.keys()),

This comment has been minimized.

Copy link
@QuentinBrosse

@ansibot ansibot removed the needs_triage label May 15, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 23, 2019

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/scaleway/scaleway_lb_backend.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/scaleway/scaleway_lb_backend.py:0:0: missing documentation (or could not parse documentation): expected string or buffer

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/cloud/scaleway/scaleway_lb_backend.py:0:0: missing documentation (or could not parse documentation): expected string or bytes-like object

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/scaleway/scaleway_lb_backend.py:0:0: missing documentation (or could not parse documentation): expected string or bytes-like object

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/scaleway/scaleway_lb_backend.py:0:0: missing documentation (or could not parse documentation): expected string or bytes-like object

The test ansible-test sanity --test ansible-doc --python 3.8 [explain] failed with 1 error:

lib/ansible/modules/cloud/scaleway/scaleway_lb_backend.py:0:0: missing documentation (or could not parse documentation): expected string or bytes-like object

The test ansible-test sanity --test docs-build [explain] failed with 2 errors:

docs/docsite/rst/modules/list_of_all_modules.rst:2368:0: undefined-label: undefined label: scaleway_lb_backend_module (if the link has no caption the label must precede a section header)
docs/docsite/rst/modules/list_of_cloud_modules.rst:1076:0: undefined-label: undefined label: scaleway_lb_backend_module (if the link has no caption the label must precede a section header)

The test ansible-test sanity --test compile --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/scaleway/scaleway_lb_backend.py:210:41: SyntaxError: attr: wished_lb_backend[attr] for attr in MUTABLE_ATTRIBUTES if target_lb_backend[attr] != wished_lb_backend[attr]

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/scaleway/scaleway_lb_backend.py:210:41: SyntaxError: invalid syntax

The test ansible-test sanity --test validate-modules [explain] failed with 15 errors:

lib/ansible/modules/cloud/scaleway/scaleway_lb_backend.py:0:0: E305 DOCUMENTATION.module: not a valid value for dictionary value @ data['module']. Got 'scaleway_lb_back'
lib/ansible/modules/cloud/scaleway/scaleway_lb_backend.py:0:0: E305 DOCUMENTATION.options.forward_port_algorithm.description.0: expected str @ data['options']['forward_port_algorithm']['description'][0]. Got {'Load balancing algorithm': None}
lib/ansible/modules/cloud/scaleway/scaleway_lb_backend.py:0:0: E305 DOCUMENTATION.options.forward_port_algorithm.description.1: expected str @ data['options']['forward_port_algorithm']['description'][1]. Got {'Round-Robin': 'Equal share'}
lib/ansible/modules/cloud/scaleway/scaleway_lb_backend.py:0:0: E305 DOCUMENTATION.options.forward_port_algorithm.description.2: expected str @ data['options']['forward_port_algorithm']['description'][2]. Got {'leastconn': 'Least amount of TCP connection'}
lib/ansible/modules/cloud/scaleway/scaleway_lb_backend.py:0:0: E307 version_added should be '2.9'. Currently '2.8'
lib/ansible/modules/cloud/scaleway/scaleway_lb_backend.py:0:0: E312 No RETURN provided
lib/ansible/modules/cloud/scaleway/scaleway_lb_backend.py:0:0: E322 Argument 'lb_id' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/cloud/scaleway/scaleway_lb_backend.py:0:0: E323 Argument 'on_marked_down_action' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/cloud/scaleway/scaleway_lb_backend.py:0:0: E323 Argument 'organization' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/cloud/scaleway/scaleway_lb_backend.py:0:0: E323 Argument 'send_proxy_v2' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/cloud/scaleway/scaleway_lb_backend.py:0:0: E323 Argument 'server_ip' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/cloud/scaleway/scaleway_lb_backend.py:0:0: E323 Argument 'sticky_sessions_cookie_name' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/cloud/scaleway/scaleway_lb_backend.py:0:0: E324 Argument 'forward_port_algorithm' in argument_spec defines default as ('roundrobin') but documentation defines default as (None)
lib/ansible/modules/cloud/scaleway/scaleway_lb_backend.py:0:0: E324 Argument 'forward_protocol' in argument_spec defines default as ('tcp') but documentation defines default as ("['tcp']")
lib/ansible/modules/cloud/scaleway/scaleway_lb_backend.py:0:0: E326 Argument 'sticky_sessions' in argument_spec defines choices as (['cookie', 'none', 'table']) but documentation defines choices as (['cookie', 'none', 'table (Will match on IP)'])

click here for bot help

@ansibot ansibot added the stale_ci label May 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.