Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consul_session: improve documentation #56392

Open
wants to merge 8 commits into
base: devel
from

Conversation

Projects
None yet
3 participants
@pilou-
Copy link
Contributor

commented May 14, 2019

SUMMARY

consul_session:

  • add doc for id parameter
  • use formatting functions in parameter descriptions
  • use required_if
  • parameters: document all types
  • add integration tests
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

consul_session

ADDITIONAL INFORMATION

@mattclay should https://ansible-ci-files.s3.amazonaws.com be used with Consul binaries (available there: https://releases.hashicorp.com/consul/1.5.0/) ?

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 14, 2019

Show resolved Hide resolved test/integration/targets/consul/aliases Outdated
Show resolved Hide resolved test/integration/targets/consul/tasks/main.yml Outdated
Show resolved Hide resolved test/integration/targets/consul/tasks/main.yml Outdated
Show resolved Hide resolved test/integration/targets/consul/tasks/main.yml Outdated

@pilou- pilou- force-pushed the pilou-:consul_session branch from fc233fa to 4ae2a1b May 14, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 14, 2019

@ansibot ansibot removed the needs_triage label May 14, 2019

@pilou- pilou- force-pushed the pilou-:consul_session branch 2 times, most recently from ba6be75 to e578218 May 14, 2019

@pilou- pilou- changed the title [WIP] consul_session: improve documentation consul_session: improve documentation May 14, 2019

@ansibot ansibot added needs_revision and removed WIP labels May 14, 2019

@pilou- pilou- force-pushed the pilou-:consul_session branch 4 times, most recently from fa24e25 to 7688452 May 14, 2019

pilou- added some commits May 14, 2019

consul_session: improve parameter descriptions
- use formatting functions in descriptions
- 'name' parameter is required when state=node

@pilou- pilou- force-pushed the pilou-:consul_session branch from 7688452 to 250e423 May 15, 2019

@pilou- pilou- force-pushed the pilou-:consul_session branch 2 times, most recently from 9077da7 to cbdafa7 May 15, 2019

pilou- and others added some commits May 14, 2019

Use ansible-ci-files bucket for consul binaries
Co-Authored-By: Matt Clay <matt@mystile.com>

@pilou- pilou- force-pushed the pilou-:consul_session branch from cbdafa7 to cc7f512 May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.