Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update azure_rm_availabilityset related module document #56432

Merged
merged 11 commits into from May 20, 2019

Conversation

Projects
None yet
6 participants
@Fred-sun
Copy link
Contributor

commented May 15, 2019

SUMMARY

Update azure_rm_availabilityset related module document.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

azure_rm_availabilityset/azure_rm_availabilityset_facts

ADDITIONAL INFORMATION

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 15, 2019

@Fred-sun this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 15, 2019

@Fred-sun, just so you are aware we have a dedicated Working Group for azure.
You can find other people interested in this in #ansible-azure on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@Fred-sun Fred-sun force-pushed the Fred-sun:azure_rm_availabilityset branch from 180233e to 254e9c6 May 15, 2019

@ansibot

This comment has been minimized.

Show resolved Hide resolved lib/ansible/modules/cloud/azure/azure_rm_availabilityset.py Outdated
Show resolved Hide resolved lib/ansible/modules/cloud/azure/azure_rm_availabilityset.py Outdated
Show resolved Hide resolved lib/ansible/modules/cloud/azure/azure_rm_availabilityset.py
@@ -93,7 +94,7 @@

RETURN = '''
state:
description: Current state of the availability set
description: Current state of the availability set.
returned: always
type: dict

This comment has been minimized.

Copy link
@yuwzho

yuwzho May 15, 2019

Contributor

fill the contains, the options are mentioned in

def availability_set_to_dict(avaset):

Show resolved Hide resolved lib/ansible/modules/cloud/azure/azure_rm_availabilityset.py Outdated
Show resolved Hide resolved lib/ansible/modules/cloud/azure/azure_rm_availabilityset_facts.py

@ansibot ansibot removed the needs_triage label May 15, 2019

Fred-sun added some commits May 15, 2019

returned: always
type: dict
example: {

This comment has been minimized.

Copy link
@yuwzho

yuwzho May 15, 2019

Contributor

It should not only give an example. But some yaml files, you can refer the servicebus module’s doc

Fred-sun added some commits May 16, 2019

@Fred-sun

This comment has been minimized.

Copy link
Contributor Author

commented May 20, 2019

ready_for_review

@yuwzho

This comment has been minimized.

Copy link
Contributor

commented May 20, 2019

@Fred-sun Please also fill the return part of the facts module

Fred-sun added some commits May 20, 2019

@yuwzho

This comment has been minimized.

Copy link
Contributor

commented May 20, 2019

shipit

1 similar comment
@yungezz

This comment has been minimized.

Copy link
Contributor

commented May 20, 2019

shipit

@acozine

This comment has been minimized.

Copy link
Contributor

commented May 20, 2019

Merging based on the double shipits. Thanks everybody.

@acozine acozine merged commit d56c975 into ansible:devel May 20, 2019

1 check passed

Shippable Run 123529 status is SUCCESS.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.