Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pluribus Network vrouter ospf module with unit tests #56435

Merged
merged 3 commits into from May 20, 2019

Conversation

Projects
None yet
3 participants
@rajaspachipulusu17
Copy link
Contributor

commented May 15, 2019

SUMMARY

Pluribus Network vrouter ospf module with unit test cases

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

Point feature of vrouter ospf module
pn_vrouter_ospf.py with unit tests.

ADDITIONAL INFORMATION
ansible 2.7.5
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python2.7/dist-packages/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.12 (default, Nov 12 2018, 14:36:49) [GCC 5.4.0 20160609]
@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 15, 2019

@rajaspachipulusu17, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

- This module can be used to add OSPF protocol to vRouter
and remove OSPF protocol from a vRouter
options:
pn_cliswitch:

This comment has been minimized.

Copy link
@justjais

justjais May 15, 2019

Contributor

@rajaspachipulusu17 as mentioned in my earlier comments in other pluribus PRs, you have to make 1/some params as mandatory i.e. required: true, else user can just run the module without passing any param to the module.

This comment has been minimized.

Copy link
@rajaspachipulusu17

rajaspachipulusu17 May 15, 2019

Author Contributor

@justjais i think user cant execute without passing arguments, because i have used required_if condition, is that good enough?

This comment has been minimized.

Copy link
@justjais

justjais May 15, 2019

Contributor

@rajaspachipulusu17 ok, in this case u can mention ['pn_vrouter_name', 'pn_network'] params as required: true, as for the state option respective params are required to be passed by user.

This comment has been minimized.

Copy link
@rajaspachipulusu17

rajaspachipulusu17 May 15, 2019

Author Contributor

@justjais i have made the change which you suggested :)

@ansibot ansibot removed the needs_triage label May 15, 2019

@rajaspachipulusu17

This comment has been minimized.

Copy link
Contributor Author

commented May 20, 2019

Can someone merge if there is no issue? @justjais @ganeshrn .

Thanks,
Rajas

@justjais justjais merged commit 7a615a9 into ansible:devel May 20, 2019

1 check passed

Shippable Run 122876 status is SUCCESS.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.