Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
New user device module for Fortinet's FortiOS and HTTPAPI plugin #56447
Fortinet is adding Ansible support for FortiOS and FortiGate products. This module follows the same structure, guidelines and ideas given in previous approved module for a parallel feature of FortiGate (webfiltering): #37196
Please note that this will be part of other modules to come for FortiGate, including different functionalities: system, wireless-controller, firewall, webfilter, ips, web-proxy, wanopt, application, dlp spamfilter, log, vpn, certificate, user, dnsfilter, antivirus, report, waf, authentication, switch controller, endpoint-control and router. We plan to follow the same style, structure and usage as in the previous module in order to make it easier to comply with Ansible guidelines.
Also, this PR includes a new HTTPAPI plugin for FortiOS, as suggested by Ansible guidelines.
This PR has been updated according to suggestions and code reviews given in previous submissions of Fortinet modules.
Sure, I can split into two PRs. However I had the impression from the previous long discussions we had and due to the amount of PRs already submitted that you wanted to minimize the number of PRs for Fortinet. That's the main reason why I put this two together. Are you sure you want to have this separated? Can you confirm with @gundalow ?
Btw, it seems that the last commit made Shippable to fail, but apparently I can't see a logical reason that ties the changes with the failures. Could it be due to a temporary fail in Shippable? (I have seen similar weird and random errors other times).
Shippable failed again, due to strange errors.
However this does not have anything to do with the changes in this PR. 'vsphere_copy.py' has not been modified at all.