Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dns_domain into os_network.py #56453

Open
wants to merge 3 commits into
base: devel
from

Conversation

Projects
None yet
5 participants
@StingRayZA
Copy link

commented May 15, 2019

SUMMARY

Adds dns_domain parameter into the os_network module

Fixes: #19622

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

cloud / openstack / os_network

ADDITIONAL INFORMATION
- os_network:
    cloud: mycloud
    state: present
    name: priv_network
    dns_domain: sample.openstack.org.
@mnaser

This comment has been minimized.

Copy link
Contributor

commented May 15, 2019

shipit

@opendev-zuul

This comment has been minimized.

Copy link

commented May 15, 2019

Build failed (third-party-check pipeline) integration testing with
OpenStack. For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

@opendev-zuul

This comment has been minimized.

Copy link

commented May 15, 2019

Build failed (third-party-check pipeline) integration testing with
OpenStack. For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

@StingRayZA

This comment has been minimized.

Copy link
Author

commented May 15, 2019

Urk. I'm submitting a patch to openstacksdk to enable the option. I'll revitalise this when its merged...

upstream patch: https://review.opendev.org/659366

@StingRayZA StingRayZA closed this May 18, 2019

@StingRayZA StingRayZA reopened this May 18, 2019

@opendev-zuul

This comment has been minimized.

Copy link

commented May 18, 2019

Build succeeded (third-party-check pipeline).

@StingRayZA

This comment has been minimized.

Copy link
Author

commented May 19, 2019

upstream has merged, and this is now passing 😁

@jamescassell
Copy link
Contributor

left a comment

shipit

@StingRayZA

This comment has been minimized.

Copy link
Author

commented May 22, 2019

@ansibot bot_status

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 22, 2019

Components

changelogs/fragments/56453-os-network-dns_domain-support-on-create-update.yml
support: community
maintainers:

lib/ansible/modules/cloud/openstack/os_network.py
support: community
maintainers: Shrews cloudnull dagnello emonty evrardjp gtema juliakreger mnaser odyssey4me rcarrillocruz

Metadata

waiting_on: maintainer
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 0
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 0
shipit_actors (maintainer or core team member): []
shipit_actors_other: jamescassell
automerge: automerge shipit test failed

click here for bot help

@mnaser

This comment has been minimized.

Copy link
Contributor

commented May 22, 2019

shipit

1 similar comment
@emonty

This comment has been minimized.

Copy link
Contributor

commented May 22, 2019

shipit

@ansibot ansibot added shipit and removed community_review labels May 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.