Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

register: fail when invalid var name is specified #56456

Merged
merged 3 commits into from May 17, 2019

Conversation

Projects
None yet
4 participants
@mkrizek
Copy link
Contributor

commented May 15, 2019

SUMMARY

Related #56042

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/executor/task_executor.py

@bcoca

bcoca approved these changes May 15, 2019

@ansibot ansibot added needs_revision and removed core_review labels May 15, 2019

@ansibot ansibot added the net_tools label May 15, 2019

@bcoca

This comment has been minimized.

Copy link
Member

commented May 15, 2019

we might also want to check against INVALID_VARIABLE_NAMES

@sivel

This comment has been minimized.

Copy link
Member

commented May 15, 2019

This can be for a later PR, but we need to extend this to all variables. We enforce it for vars in a playbook also, but not for extra vars, or inventory, etc...

But this is a step in the right direction.

See:

TODO: add this to VariableManager to validate vars loaded from files too

@sivel

sivel approved these changes May 15, 2019

@bcoca

This comment has been minimized.

Copy link
Member

commented May 15, 2019

yeah, fine with PR as is, just made comment/note for future

@bcoca

bcoca approved these changes May 15, 2019

@mkrizek mkrizek merged commit c6b40f4 into ansible:devel May 17, 2019

1 check passed

Shippable Run 123280 status is SUCCESS.
Details

@mkrizek mkrizek deleted the mkrizek:register-invalid-var-name branch May 17, 2019

@sivel sivel removed the needs_triage label May 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.