Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix chech_mode in ec2_instance #56474
This bugfix repairs bug in ec2_instance module during check_mode.
When I run a step with ec2_instance module, there is a bug in check_mode. The step will rename all the tags in matched ec2 instances even in check_mode. This bugfix repairs this bug.
abadger left a comment
This change does not appear in devel and the stable-2.8 branches. Unless there's a reason that this is not needed there, bugfixes need to be applied to devel and then backported to the stable-X.Y branches. Otherwise, regressions can happen when a user upgrades from 2.7.x to the next release.
If you'd care to resubmit this against the devel branch, that would be great.
If you'd want it backported after that, it will also need a changelog entry. Thanks.
2.7.11 is being released on Thursday. We try to merge all backports on Monday before the release so that other projects, sites, and people have a chance to test the upcoming tree before a release. This PR was not ready to merge on Monday so it won't go into 2.7.11 unless 2.7.11 is delayed.
2.7.11 is also the last release in the 2.7.x series which will contain non-critical bugfixes. We don't think this qualifies as a critical bugfix so I will be closing it after the release on Thursday. If you think this is critical, please take it to a Core Team IRC meeting ( https://github.com/ansible/community/tree/master/meetings ) to have a vote on whether to either slip the 2.7.11 release to get it in or to release a 2.7.12 with this change included.