Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chech_mode in ec2_instance #56474

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
5 participants
@fridlik
Copy link

commented May 15, 2019

SUMMARY

This bugfix repairs bug in ec2_instance module during check_mode.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

cloud/aws/ec2_instance

ADDITIONAL INFORMATION

When I run a step with ec2_instance module, there is a bug in check_mode. The step will rename all the tags in matched ec2 instances even in check_mode. This bugfix repairs this bug.

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 15, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 15, 2019

@fridlik, just so you are aware we have a dedicated Working Group for aws.
You can find other people interested in this in #ansible-aws on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@abadger
Copy link
Member

left a comment

This change does not appear in devel and the stable-2.8 branches. Unless there's a reason that this is not needed there, bugfixes need to be applied to devel and then backported to the stable-X.Y branches. Otherwise, regressions can happen when a user upgrades from 2.7.x to the next release.

If you'd care to resubmit this against the devel branch, that would be great.

If you'd want it backported after that, it will also need a changelog entry. Thanks.

@ansibot ansibot removed the needs_triage label May 21, 2019

@Shaps

This comment has been minimized.

Copy link
Contributor

commented May 21, 2019

@fridlik yes, this would happen in devel too, change the base branch to it so we can get this merged, we'll then get backport PRs to stable-2.7 and stable-2.8. Please add a changelog fragment to this PR as well.

@abadger

This comment has been minimized.

Copy link
Member

commented May 21, 2019

2.7.11 is being released on Thursday. We try to merge all backports on Monday before the release so that other projects, sites, and people have a chance to test the upcoming tree before a release. This PR was not ready to merge on Monday so it won't go into 2.7.11 unless 2.7.11 is delayed.

2.7.11 is also the last release in the 2.7.x series which will contain non-critical bugfixes. We don't think this qualifies as a critical bugfix so I will be closing it after the release on Thursday. If you think this is critical, please take it to a Core Team IRC meeting ( https://github.com/ansible/community/tree/master/meetings ) to have a vote on whether to either slip the 2.7.11 release to get it in or to release a 2.7.12 with this change included.

@fridlik fridlik changed the base branch from stable-2.7 to devel May 21, 2019

@fridlik fridlik changed the base branch from devel to stable-2.7 May 21, 2019

@fridlik fridlik force-pushed the fridlik:aws_ec2_instance branch from 458ec7b to 6ca1d66 May 21, 2019

@fridlik fridlik changed the base branch from stable-2.7 to devel May 21, 2019

@fridlik

This comment has been minimized.

Copy link
Author

commented May 21, 2019

@abadger I changed the base branch, so it could be merged into devel now. I think it is not so critical bug, so it is enought to be merged into devel only and backported into stable-2.8.
@Shaps changelog fragment: "ec2_instance - fix tags rename in check mode"

@Shaps

This comment has been minimized.

Copy link
Contributor

commented May 21, 2019

@fridlik Yes, that's what the changelog would look like. Follow the steps in the docs, also make sure you rebase the PR as there seem to be lots of conflicts.

@abadger Yeah, unless 2.7.11 is postponed it's fine we can avoid backporting it to 2.7

@mattclay

This comment has been minimized.

Copy link
Member

commented May 23, 2019

Closing and re-opening to correct CI issues.

@mattclay mattclay closed this May 23, 2019

@mattclay mattclay reopened this May 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.