Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os_port allowed_address_pairs and extra_dhcp_opts list of dicts comparison fix #56577

Open
wants to merge 4 commits into
base: devel
from

Conversation

Projects
None yet
2 participants
@acalm
Copy link
Contributor

commented May 17, 2019

SUMMARY

Fixes #47182, previously the comparison of list dicts would blindly compare the lists and trigger a change if the order of both list and dicts didn't match exactly, this change tries to ignore order, by re-ordering before comparing.

I also updated the extra_dhcp_opts docs.

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
COMPONENT NAME

os_port

ADDITIONAL INFORMATION

@acalm acalm changed the title Fix 47182 os_port allowed_address_pairs and extra_dhcp_opts list of dicts comparison fix May 17, 2019

@opendev-zuul

This comment has been minimized.

Copy link

commented May 17, 2019

Build succeeded (third-party-check pipeline).

@ansibot ansibot added the stale_ci label May 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.