Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vmware_guest: clone VM with attached CDROM #56593

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
2 participants
@goneri
Copy link
Contributor

commented May 17, 2019

SUMMARY

If a VM has an attached CDROM, backing attribute of the CDROM will
be defined.
As a result, we cannot just loop vm_obj.config.hardware.device and check
for the existance of the attribute to decide if the entry is a
harddrive.

Instead, we check the type of the device, and only keep the
vim.vm.device.VirtualDisk disk.

This issue is actually breaking our test-suite with regular environment
because we keep a Fedora ISO attached to the VM.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

vmware_guest

vmware_guest: clone VM with attached CDROM
If a VM has an attached CDROM, `backing` attribute of the CDROM will
be defined.
As a result, we cannot just loop `vm_obj.config.hardware.device` and check
for the existance of the attribute to decide if the entry is a
harddrive.

Instead, we check the type of the device, and only keep the
`vim.vm.device.VirtualDisk` disk.

This issue is actually breaking our test-suite with regular environment
because we keep a Fedora ISO attached to the VM.
@ansibot

This comment has been minimized.

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.