-
Notifications
You must be signed in to change notification settings - Fork 23.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[facts] iscsi fixes, add/fix solaris discovery for iscsi iqn #56603
Open
mator
wants to merge
4
commits into
ansible:devel
Choose a base branch
from
mator:facts_iscsi_fixes
base: devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+38
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.9
This issue/PR affects Ansible v2.9
core_review
In order to be merged, this PR must follow the core review workflow.
feature
This issue/PR relates to a feature request.
needs_triage
Needs a first human triage before being processed.
support:core
This issue/PR relates to code supported by the Ansible Engineering Team.
labels
May 17, 2019
samdoran
added
P3
Priority 3 - Approved, No Time Limitation
and removed
needs_triage
Needs a first human triage before being processed.
labels
May 23, 2019
ansibot
added
support:community
This issue/PR relates to code supported by the Ansible community.
bug
This issue/PR relates to a bug.
labels
May 27, 2019
ansibot
added
the
stale_ci
This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested.
label
Jun 6, 2019
ansibot
removed
the
stale_ci
This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested.
label
Jul 4, 2019
ansibot
added
the
stale_ci
This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested.
label
Jul 13, 2019
mator
force-pushed
the
facts_iscsi_fixes
branch
from
October 30, 2019 09:15
2c5fe95
to
fd9ccb3
Compare
ansibot
removed
the
stale_ci
This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested.
label
Oct 30, 2019
ansibot
added
the
stale_ci
This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested.
label
Nov 8, 2019
ansibot
added
needs_rebase
https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
and removed
core_review
In order to be merged, this PR must follow the core review workflow.
labels
Feb 4, 2020
ansibot
added
pre_azp
This PR was last tested before migration to Azure Pipelines.
and removed
stale_ci
This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested.
labels
Dec 5, 2020
ansibot
removed
the
support:community
This issue/PR relates to code supported by the Ansible community.
label
Mar 5, 2021
ansibot
added
needs_rebase
https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html
and removed
needs_rebase
https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html
labels
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
affects_2.9
This issue/PR affects Ansible v2.9
bug
This issue/PR relates to a bug.
feature
This issue/PR relates to a feature request.
needs_rebase
https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
P3
Priority 3 - Approved, No Time Limitation
pre_azp
This PR was last tested before migration to Azure Pipelines.
support:core
This issue/PR relates to code supported by the Ansible Engineering Team.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Add/fix solaris iscsi iqn discovery. Strip leading whitespace from HP-UX iscsi iqn.
ISSUE TYPE
COMPONENT NAME
facts module
ADDITIONAL INFORMATION
There's no
/etc/iscsi/initiatorname.iscsi
on solaris (checked on solaris 10 and solaris 11, besides no mentions of this file in Solaris documentation), so useiscsiadm
for discovery.Before:
after: