Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[facts] iscsi fixes, add/fix solaris discovery for iscsi iqn #56603

Open
wants to merge 4 commits into
base: devel
Choose a base branch
from

Conversation

mator
Copy link
Contributor

@mator mator commented May 17, 2019

SUMMARY

Add/fix solaris iscsi iqn discovery. Strip leading whitespace from HP-UX iscsi iqn.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

facts module

ADDITIONAL INFORMATION

There's no /etc/iscsi/initiatorname.iscsi on solaris (checked on solaris 10 and solaris 11, besides no mentions of this file in Solaris documentation), so use iscsiadm for discovery.

Before:

$ ansible -m setup solaris10 -a "filter=ansible_iscsi*"   
solaris10 | SUCCESS => {
    "ansible_facts": {
        "ansible_iscsi_iqn": "", 
        "discovered_interpreter_python": "/usr/bin/python"
    }, 
    "changed": false
}

after:

$ ansible -m setup solaris10 -a "filter=ansible_iscsi*"
solaris10 | SUCCESS => {
    "ansible_facts": {
        "ansible_iscsi_iqn": "iqn.1986-03.com.sun:01:7a8102f8ffff.50fedbb9", 
        "discovered_interpreter_python": "/usr/bin/python"
    }, 
    "changed": false
}

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels May 17, 2019
@samdoran samdoran added P3 Priority 3 - Approved, No Time Limitation and removed needs_triage Needs a first human triage before being processed. labels May 23, 2019
@ansibot ansibot added support:community This issue/PR relates to code supported by the Ansible community. bug This issue/PR relates to a bug. labels May 27, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jun 6, 2019
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jul 4, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jul 13, 2019
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 30, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Nov 8, 2019
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Feb 4, 2020
@ansibot ansibot added pre_azp This PR was last tested before migration to Azure Pipelines. and removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Dec 5, 2020
@ansibot ansibot removed the support:community This issue/PR relates to code supported by the Ansible community. label Mar 5, 2021
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. feature This issue/PR relates to a feature request. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. P3 Priority 3 - Approved, No Time Limitation pre_azp This PR was last tested before migration to Azure Pipelines. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants