Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[facts] iscsi fixes, add/fix solaris discovery for iscsi iqn #56603

Open
wants to merge 4 commits into
base: devel
from

Conversation

Projects
None yet
3 participants
@mator
Copy link
Contributor

commented May 17, 2019

SUMMARY

Add/fix solaris iscsi iqn discovery. Strip leading whitespace from HP-UX iscsi iqn.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

facts module

ADDITIONAL INFORMATION

There's no /etc/iscsi/initiatorname.iscsi on solaris (checked on solaris 10 and solaris 11, besides no mentions of this file in Solaris documentation), so use iscsiadm for discovery.

Before:

$ ansible -m setup solaris10 -a "filter=ansible_iscsi*"   
solaris10 | SUCCESS => {
    "ansible_facts": {
        "ansible_iscsi_iqn": "", 
        "discovered_interpreter_python": "/usr/bin/python"
    }, 
    "changed": false
}

after:

$ ansible -m setup solaris10 -a "filter=ansible_iscsi*"
solaris10 | SUCCESS => {
    "ansible_facts": {
        "ansible_iscsi_iqn": "iqn.1986-03.com.sun:01:7a8102f8ffff.50fedbb9", 
        "discovered_interpreter_python": "/usr/bin/python"
    }, 
    "changed": false
}

@mator mator force-pushed the mator:facts_iscsi_fixes branch from 52f2310 to 396fdde May 18, 2019

@samdoran samdoran added P3 and removed needs_triage labels May 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.