Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] New module - meraki_mx_uplink #56684

Open
wants to merge 2 commits into
base: devel
from

Conversation

Projects
None yet
2 participants
@kbreit
Copy link
Contributor

commented May 21, 2019

SUMMARY

New module for viewing and configuring uplinks on MX appliances.

  • Documentation still needs to be done

Fixes #56630

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

meraki_mx_uplink

ADDITIONAL INFORMATION
TASK [meraki_mx_uplink : Set MX uplink settings with check mode] ********************************************************
changed: [localhost]

TASK [meraki_mx_uplink : debug] *****************************************************************************************
ok: [localhost] =>
  set_bw_check:
    changed: true
    data:
      cellular:
        bandwidth_limits:
          limit_down: 0
          limit_up: 0
      wan1:
        bandwidth_limits:
          limit_down: 1000000
          limit_up: 100
    diff:
      after:
        wan1:
          bandwidth_limits:
            limit_up: 100
      before:
        wan1:
          bandwidth_limits:
            limit_up: 1000000
    failed: false
    response: OK (unknown bytes)
    status: 200

TASK [meraki_mx_uplink : assert] ****************************************************************************************
ok: [localhost] => changed=false
  msg: All assertions passed

TASK [meraki_mx_uplink : Set MX uplink settings] ************************************************************************
changed: [localhost]

TASK [meraki_mx_uplink : debug] *****************************************************************************************
ok: [localhost] =>
  set_bw:
    changed: true
    data:
      cellular:
        bandwidth_limits:
          limit_down: 0
          limit_up: 0
      wan1:
        bandwidth_limits:
          limit_down: 1000000
          limit_up: 1000
    diff:
      after:
        wan1:
          bandwidth_limits:
            limit_up: 1000
      before:
        wan1:
          bandwidth_limits:
            limit_up: 1000000
    failed: false
    response: OK (unknown bytes)
    status: 200

TASK [meraki_mx_uplink : assert] ****************************************************************************************
ok: [localhost] => changed=false
  msg: All assertions passed

TASK [meraki_mx_uplink : Set MX uplink settings with idempotency] *******************************************************
ok: [localhost]

TASK [meraki_mx_uplink : debug] *****************************************************************************************
ok: [localhost] =>
  set_bw_idempotent:
    changed: false
    data:
      cellular:
        bandwidth_limits:
          limit_down: 0
          limit_up: 0
      wan1:
        bandwidth_limits:
          limit_down: 1000000
          limit_up: 1000
    failed: false
    response: OK (unknown bytes)
    status: 200

TASK [meraki_mx_uplink : assert] ****************************************************************************************
ok: [localhost] => changed=false
  msg: All assertions passed

TASK [meraki_mx_uplink : Query MX uplink settings] **********************************************************************
ok: [localhost]

TASK [meraki_mx_uplink : debug] *****************************************************************************************
ok: [localhost] =>
  query_all:
    changed: false
    data:
      cellular:
        bandwidth_limits:
          limit_down: 0
          limit_up: 0
      wan1:
        bandwidth_limits:
          limit_down: 1000000
          limit_up: 1000
    failed: false
    response: OK (unknown bytes)
    status: 200

TASK [meraki_mx_uplink : assert] ****************************************************************************************
ok: [localhost] => changed=false
  msg: All assertions passed

@kbreit kbreit changed the title New module - meraki_mx_uplink [WIP] New module - meraki_mx_uplink May 21, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 21, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 29, 2019

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/network/meraki/meraki_mx_uplink.py:295:161: E501 line too long (162 > 160 characters)

The test ansible-test sanity --test validate-modules [explain] failed with 5 errors:

lib/ansible/modules/network/meraki/meraki_mx_uplink.py:0:0: E322 Argument 'cellular' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/meraki/meraki_mx_uplink.py:0:0: E322 Argument 'wan1' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/meraki/meraki_mx_uplink.py:0:0: E322 Argument 'wan2' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/meraki/meraki_mx_uplink.py:0:0: E323 Argument 'vlan_id' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/network/meraki/meraki_mx_uplink.py:0:0: E325 Argument 'org_id' in argument_spec defines type as 'str' but documentation defines type as 'int'

click here for bot help

@kbreit kbreit force-pushed the kbreit:meraki/meraki_mx_uplink branch from 9c5cc2f to 08817e9 Jun 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.