Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module_utils/docker/swarm.py: change license from GPLv3+ to BSD. #56691

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
4 participants
@felixfontein
Copy link
Contributor

commented May 21, 2019

SUMMARY

It has recently be clarified that while modules in module_utils can be GPLv3+ licensed, they shouldn't be if possible. Since module_utils/docker/swarm.py is relatively new and has been based on module code (which was GPLv3+ in the first place), I'm trying to change the license.

For this, everyone who participated in changes to this file needs to explicitly approve the license change. These are (next to me) @WojciechowskiPiotr and @hannseman (see history 1, history 2).

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/module_utils/docker/swarm.py

@hannseman

This comment has been minimized.

Copy link
Contributor

commented May 21, 2019

I approve the change of license from GPLv3+ to BSD of module_utils/docker/swarm.py.

@ansibot

This comment has been minimized.

@felixfontein

This comment has been minimized.

Copy link
Contributor Author

commented May 21, 2019

Ok, I got a bit confused: this of course also needs the approval of the authors of the docker_swarm module which touched parts of the code which were moved here. I'll dig into who exactly did that this evening. Anyway, someone who definitely needs to approve is @tbouvet!

@WojciechowskiPiotr

This comment has been minimized.

Copy link
Contributor

commented May 21, 2019

I'm ok with the change. I used part of @tbouvet code so his approval is required as well.

@ansibot ansibot removed the needs_triage label May 21, 2019

@felixfontein

This comment has been minimized.

Copy link
Contributor Author

commented May 21, 2019

I checked the commit history for the docker_swarm module. Nobody else than @tbouvet (and potentially the people already mentioned in this thread, haven't checked our commits :) ) touched any code which got moved into module_utils.

@ansibot ansibot added the stale_ci label May 29, 2019

@felixfontein

This comment has been minimized.

Copy link
Contributor Author

commented Jun 8, 2019

@tbouvet are you still around?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.