Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In tower_credential module, add credential_type parameter #56692

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
3 participants
@jladdjr
Copy link
Contributor

commented May 21, 2019

SUMMARY

Adds the credential_type parameter to the tower_credential module. This will allow users to create credentials that use custom credential types.

The kind parameter is still supported for backwards compatibility.

Fixes #54493

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

tower_credential module

@ansibot

This comment has been minimized.

params['credential_type'] = credential_type['id']
if module.params.get('credential_type'):
credential_type_res = tower_cli.get_resource('credential_type')
credential_type = credential_type_res.get(name=module.params['credential_type'])

This comment has been minimized.

Copy link
@AlanCoding

AlanCoding May 21, 2019

Member

I'm not a fan of this, because credential type is not unique based on name, and because tower-cli already does a name-based lookup (again, which is wrong) of the related field in the call to the modify method.

But this looks like it's mostly the same as how organization is handled, so I'm trending toward saying this is right for now.

@AlanCoding
Copy link
Member

left a comment

I think it would be prudent to raise an error if both credential_type and kind are provided.

@jladdjr jladdjr force-pushed the jladdjr:tower_cred_type_devel branch from 9b8cd8a to ef1b298 May 21, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.