Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added gcp_kms filters filter plugin #56755

Open
wants to merge 3 commits into
base: devel
from

Conversation

Projects
None yet
4 participants
@ericsysmin
Copy link
Contributor

commented May 21, 2019

SUMMARY

new filter to permit encrypt and decrypt via gcp_kms

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

gcp_kms_encrypt
gcp_kms_decrypt

ADDITIONAL INFORMATION

Allows encryption and decryption against GCP KMS

vars:
  encrypted_myvar: "{{ var | b64encode | gcp_kms_encrypt(auth_kind='serviceaccount',
    service_account_file='gcp_service_account_file', projects='default',
    key_ring='key_ring', crypto_key='crypto_key') }}"
  decrypted_myvar: "{{ encrypted_myvar | gcp_kms_decrypt(auth_kind='serviceaccount',
    service_account_file=gcp_service_account_file, projects='default',
    key_ring='key_ring', crypto_key='crypto_key') }}"

ericsysmin added some commits May 21, 2019

@ericsysmin

This comment has been minimized.

Copy link
Contributor Author

commented May 24, 2019

@rambleraptor can you do the community review?

@ansibot ansibot added the stale_ci label Jun 1, 2019

@rambleraptor

This comment has been minimized.

Copy link
Contributor

commented Jun 17, 2019

This looks great! Thanks for the PR

shipit

@rambleraptor

This comment has been minimized.

Copy link
Contributor

commented Jun 19, 2019

@gundalow can you take a look at this?

@kustodian

This comment has been minimized.

Copy link
Contributor

commented Jun 20, 2019

This looks great. Just a thing I was looking for.

Would you be able to add environment variables as a fallback, so that it's easier to work with the filter? You can check which vars exist in gcp_utils.py.

@ericsysmin

This comment has been minimized.

Copy link
Contributor Author

commented Jun 20, 2019

This looks great. Just a thing I was looking for.

Would you be able to add environment variables as a fallback, so that it's easier to work with the filter? You can check which vars exist in gcp_utils.py.

You can make the changes you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.