Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s3_website: add check mode support and unit tests #56777

Open
wants to merge 4 commits into
base: devel
from

Conversation

Projects
None yet
6 participants
@zyv
Copy link
Contributor

commented May 22, 2019

SUMMARY

This PR adds check mode support to s3_website.

On top of that, we have covered the module with unit test to make sure future changes won't break existing logic.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

s3_website

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 22, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 22, 2019

@zyv, just so you are aware we have a dedicated Working Group for aws.
You can find other people interested in this in #ansible-aws on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added core_review and removed needs_revision labels May 22, 2019

@zyv

This comment has been minimized.

Copy link
Contributor Author

commented May 22, 2019

@samdoran samdoran removed the needs_triage label May 23, 2019

@marns93
Copy link
Contributor

left a comment

LGTM

@jillr

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2019

Thanks very much for the unit tests. Would you be able to add some integration tests with this?

@ansibot ansibot added the stale_ci label Jun 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.