Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VMware: add facts about tags in vmware_cluster_facts #56848

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
3 participants
@Akasurde
Copy link
Member

commented May 23, 2019

SUMMARY

Fixes: #46458

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

changelogs/fragments/46458-vmware_cluster_facts-show_tag.yml
lib/ansible/modules/cloud/vmware/vmware_cluster_facts.py
test/integration/targets/prepare_vmware_tests/tasks/init_real_lab.yml
test/integration/targets/prepare_vmware_tests/tasks/setup_category.yml
test/integration/targets/prepare_vmware_tests/tasks/setup_tag.yml
test/integration/targets/prepare_vmware_tests/vars/real_lab.yml
test/integration/targets/vmware_cluster_facts/tasks/main.yml

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 23, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_cluster_facts.py:108:19: E313 RETURN is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_cluster_facts.py:108:19: error RETURN: syntax error: expected ',' or '}', but got ':'

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 23, 2019

@ansibot ansibot removed the needs_triage label May 23, 2019

@Akasurde Akasurde force-pushed the Akasurde:i46458 branch 3 times, most recently from 5eeaa14 to 1440606 May 24, 2019

@ansibot ansibot added needs_rebase and removed ci_verified labels May 24, 2019

VMware: add facts about tags in vmware_cluster_facts
Fixes: #46458

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>

@Akasurde Akasurde force-pushed the Akasurde:i46458 branch from 1440606 to 7982e12 May 24, 2019

@ansibot ansibot removed the needs_rebase label May 24, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 1, 2019

@Akasurde Akasurde requested a review from goneri Jun 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.