Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slack: fix thread_id type #56862

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
4 participants
@wolfman-rack
Copy link

commented May 23, 2019

SUMMARY

Changed type of thread_id from float to str. This fixes an issue where thread_id ends in any 0s

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

slack

ADDITIONAL INFORMATION

The field merely looks like UNIX/epoch timestamps per https://api.slack.com/docs/message-threading#finding_message_threads_in_the_wild

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 23, 2019

@ramondelafuente

This comment has been minimized.

Copy link
Contributor

commented May 24, 2019

shipit

@ansibot ansibot removed the needs_triage label May 24, 2019

@mattclay

This comment has been minimized.

Copy link
Member

commented Jun 24, 2019

Closing and re-opening to trigger CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.