Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fortinet FortiAnalyzer HTTPAPI Plugin / Module Utils / Two Modules #56890

Open
wants to merge 6 commits into
base: devel
from

Conversation

Projects
None yet
3 participants
@ftntcorecse
Copy link
Contributor

commented May 23, 2019

SUMMARY

This is the first attempt/commit from FTNT for the FortiAnalyzer plugin and module_utils and modules.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

@ansibot

This comment has been minimized.

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 23, 2019

@ftntcorecse this PR contains more than one new module.

Please submit only one new module per pull request. For a detailed explanation, please read the grouped modules documentation

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 23, 2019

@ftntcorecse, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 23, 2019

The test ansible-test sanity --test pylint [explain] failed with 2 errors:

lib/ansible/module_utils/network/fortianalyzer/fortianalyzer.py:473:0: trailing-newlines Trailing newlines
lib/ansible/module_utils/network/fortianalyzer/fortianalyzer_debug.py:55:0: syntax-error Missing parentheses in call to 'print'. Did you mean print(err)? (<unknown>, line 55)

The test ansible-test sanity --test pylint [explain] failed with 2 errors:

lib/ansible/plugins/httpapi/fortianalyzer.py:394:12: bare-except No exception type(s) specified
lib/ansible/plugins/httpapi/fortianalyzer.py:431:16: bare-except No exception type(s) specified

The test ansible-test sanity --test compile --python 3.5 [explain] failed with 1 error:

lib/ansible/module_utils/network/fortianalyzer/fortianalyzer_debug.py:55:17: SyntaxError: print err

The test ansible-test sanity --test compile --python 3.6 [explain] failed with 1 error:

lib/ansible/module_utils/network/fortianalyzer/fortianalyzer_debug.py:55:17: SyntaxError: print err

The test ansible-test sanity --test compile --python 3.7 [explain] failed with 1 error:

lib/ansible/module_utils/network/fortianalyzer/fortianalyzer_debug.py:55:17: SyntaxError: print err

The test ansible-test sanity --test compile --python 3.8 [explain] failed with 1 error:

lib/ansible/module_utils/network/fortianalyzer/fortianalyzer_debug.py:55:15: SyntaxError: print err

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

lib/ansible/module_utils/network/fortianalyzer/fortianalyzer_debug.py:55:17: SyntaxError: Missing parentheses in call to 'print'

The test ansible-test sanity --test import --python 3.6 [explain] failed with 1 error:

lib/ansible/module_utils/network/fortianalyzer/fortianalyzer_debug.py:55:17: SyntaxError: Missing parentheses in call to 'print'. Did you mean print(err)?

The test ansible-test sanity --test import --python 3.7 [explain] failed with 1 error:

lib/ansible/module_utils/network/fortianalyzer/fortianalyzer_debug.py:55:17: SyntaxError: Missing parentheses in call to 'print'. Did you mean print(err)?

The test ansible-test sanity --test import --python 3.8 [explain] failed with 1 error:

lib/ansible/module_utils/network/fortianalyzer/fortianalyzer_debug.py:55:15: SyntaxError: Missing parentheses in call to 'print'. Did you mean print(err)?

The test ansible-test sanity --test pep8 [explain] failed with 34 errors:

lib/ansible/module_utils/network/fortianalyzer/fortianalyzer.py:473:1: W391 blank line at end of file
lib/ansible/module_utils/network/fortianalyzer/fortianalyzer_debug.py:41:18: E401 multiple imports on one line
lib/ansible/module_utils/network/fortianalyzer/fortianalyzer_debug.py:42:26: E701 multiple statements on one line (colon)
lib/ansible/module_utils/network/fortianalyzer/fortianalyzer_debug.py:47:5: E722 do not use bare 'except'
lib/ansible/module_utils/network/fortianalyzer/fortianalyzer_debug.py:60:25: E126 continuation line over-indented for hanging indent
lib/ansible/module_utils/network/fortianalyzer/fortianalyzer_debug.py:64:25: E123 closing bracket does not match indentation of opening bracket's line
lib/ansible/module_utils/network/fortianalyzer/fortianalyzer_debug.py:65:5: E722 do not use bare 'except'
lib/ansible/module_utils/network/fortianalyzer/fortianalyzer_debug.py:72:5: E722 do not use bare 'except'
lib/ansible/module_utils/network/fortianalyzer/fortianalyzer_debug.py:83:5: E303 too many blank lines (2)
lib/ansible/module_utils/network/fortianalyzer/fortianalyzer_debug.py:90:9: E722 do not use bare 'except'
lib/ansible/module_utils/network/fortianalyzer/fortianalyzer_debug.py:111:11: W292 no newline at end of file
lib/ansible/modules/network/fortianalyzer/faz_device.py:36:93: W291 trailing whitespace
lib/ansible/modules/network/fortianalyzer/faz_device.py:44:1: W293 blank line contains whitespace
lib/ansible/modules/network/fortianalyzer/faz_device.py:56:1: W293 blank line contains whitespace
lib/ansible/modules/network/fortianalyzer/faz_device.py:61:1: W293 blank line contains whitespace
lib/ansible/modules/network/fortianalyzer/faz_device.py:66:1: W293 blank line contains whitespace
lib/ansible/modules/network/fortianalyzer/faz_device.py:71:1: W293 blank line contains whitespace
lib/ansible/modules/network/fortianalyzer/faz_device.py:76:1: W293 blank line contains whitespace
lib/ansible/modules/network/fortianalyzer/faz_device.py:82:1: W293 blank line contains whitespace
lib/ansible/modules/network/fortianalyzer/faz_device.py:88:1: W293 blank line contains whitespace
lib/ansible/modules/network/fortianalyzer/faz_device.py:91:35: W291 trailing whitespace
lib/ansible/modules/network/fortianalyzer/faz_device.py:93:1: W293 blank line contains whitespace
lib/ansible/modules/network/fortianalyzer/faz_device.py:98:74: W291 trailing whitespace
lib/ansible/modules/network/fortianalyzer/faz_device.py:99:1: W293 blank line contains whitespace
lib/ansible/modules/network/fortianalyzer/faz_device.py:102:80: W291 trailing whitespace
lib/ansible/modules/network/fortianalyzer/faz_device.py:104:1: W293 blank line contains whitespace
lib/ansible/modules/network/fortianalyzer/faz_device.py:109:1: W293 blank line contains whitespace
lib/ansible/modules/network/fortianalyzer/faz_device.py:126:1: W293 blank line contains whitespace
lib/ansible/modules/network/fortianalyzer/faz_device.py:141:1: W293 blank line contains whitespace
lib/ansible/plugins/httpapi/fortianalyzer.py:314:12: E111 indentation is not a multiple of four
lib/ansible/plugins/httpapi/fortianalyzer.py:394:13: E722 do not use bare 'except'
lib/ansible/plugins/httpapi/fortianalyzer.py:412:38: E231 missing whitespace after ','
lib/ansible/plugins/httpapi/fortianalyzer.py:431:17: E722 do not use bare 'except'
lib/ansible/plugins/httpapi/fortianalyzer.py:448:5: E303 too many blank lines (2)

The test ansible-test sanity --test validate-modules [explain] failed with 10 errors:

lib/ansible/modules/network/fortianalyzer/faz_device.py:0:0: E319 RETURN.api_result.type: not a valid value for dictionary value @ data['api_result']['type']. Got 'string'
lib/ansible/modules/network/fortianalyzer/faz_device.py:0:0: E326 Argument 'mgmt_mode' in argument_spec defines choices as ([]) but documentation defines choices as (['unreg', 'fmg', 'faz', 'fmgfaz'])
lib/ansible/modules/network/fortianalyzer/faz_device.py:0:0: E326 Argument 'os_type' in argument_spec defines choices as ([]) but documentation defines choices as (['unknown', 'fos', 'fsw', 'foc', 'fml', 'faz', 'fwb', 'fch', 'fct', 'log', 'fmg', 'fsa', 'fdd', 'fac'])
lib/ansible/modules/network/fortianalyzer/faz_device.py:0:0: E326 Argument 'os_ver' in argument_spec defines choices as ([]) but documentation defines choices as (['unknown', '0.0', '1.0', '2.0', '3.0', '4.0', '5.0', '6.0'])
lib/ansible/modules/network/fortianalyzer/faz_query.py:0:0: E307 version_added should be '2.9'. Currently '2.8'
lib/ansible/modules/network/fortianalyzer/faz_query.py:0:0: E323 Argument 'device_ip' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/network/fortianalyzer/faz_query.py:0:0: E323 Argument 'device_serial' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/network/fortianalyzer/faz_query.py:0:0: E323 Argument 'device_unique_name' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/network/fortianalyzer/faz_query.py:0:0: E323 Argument 'nodes' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/network/fortianalyzer/faz_query.py:0:0: E326 Argument 'object' in argument_spec defines choices as (['task', 'custom']) but documentation defines choices as (['device', 'cluster_nodes', 'task', 'custom'])

click here for bot help

@ansibot ansibot added the ci_verified label May 23, 2019

@ansibot ansibot removed the ci_verified label May 23, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 23, 2019

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/plugins/httpapi/fortianalyzer.py:448:5: E303 too many blank lines (2)

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/network/fortianalyzer/faz_device.py:0:0: E319 RETURN.api_result.type: not a valid value for dictionary value @ data['api_result']['type']. Got 'string'

click here for bot help

@ansibot ansibot added the ci_verified label May 23, 2019

@ansibot ansibot removed the ci_verified label May 24, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 24, 2019

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/plugins/httpapi/fortianalyzer.py:448:5: E303 too many blank lines (2)

click here for bot help

@ansibot ansibot added the ci_verified label May 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.