Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tower_workflow_template: Add missing options #56891

Merged
merged 1 commit into from Jun 20, 2019

Conversation

Projects
None yet
4 participants
@albertomurillo
Copy link
Contributor

commented May 24, 2019

SUMMARY

tower_workflow_template: Add missing options

The following options can be set on a workflow template but the
functionallity to do so from this module was missing.

inventory
ask_variables_on_launch
ask_inventory_on_launch

Fixes #49728

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

tower_workflow_template

ADDITIONAL INFORMATION

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 24, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 3 errors:

lib/ansible/modules/web_infrastructure/ansible_tower/tower_workflow_template.py:0:0: E309 version_added for new option (ask_extra_vars) should be '2.9'. Currently StrictVersion ('0.0')
lib/ansible/modules/web_infrastructure/ansible_tower/tower_workflow_template.py:0:0: E309 version_added for new option (ask_inventory) should be '2.9'. Currently StrictVersion ('0.0')
lib/ansible/modules/web_infrastructure/ansible_tower/tower_workflow_template.py:0:0: E309 version_added for new option (inventory) should be '2.9'. Currently StrictVersion ('0.0')

click here for bot help

@ansibot

This comment has been minimized.

tower_workflow_template: Add missing options
The following options can be set on a workflow template but the
functionallity to do so from this module was missing.

inventory
ask_variables_on_launch
ask_inventory_on_launch

Fixes #49728

Signed-off-by: Alberto Murillo <albertomurillosilva@gmail.com>
@AlanCoding

This comment has been minimized.

Copy link
Member

commented May 24, 2019

shipit

@ansibot ansibot removed the needs_triage label May 24, 2019

@albertomurillo albertomurillo force-pushed the albertomurillo:tower_workflow_template branch from 69902e0 to 104f109 May 24, 2019

@albertomurillo

This comment has been minimized.

Copy link
Contributor Author

commented May 24, 2019

shipit

@albertomurillo

This comment has been minimized.

Copy link
Contributor Author

commented May 24, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 9, 2019

@kdelee

This comment has been minimized.

Copy link

commented Jun 20, 2019

shipit

@ansibot ansibot merged commit 320d05d into ansible:devel Jun 20, 2019

1 check passed

Shippable Run 128656 status is SUCCESS.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.