Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nxos_pim: Add bfd support #56908

Merged
merged 4 commits into from Jun 19, 2019

Conversation

@chrisvanheuveln
Copy link
Contributor

commented May 24, 2019

SUMMARY

Add support for bfd state in nxos_pim

This module previously only had one command option (ssm_range) and the existing logic was built around that command, so I had to refactor somewhat to better handle add'l commands.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

nxos_pim

ADDITIONAL INFORMATION
  • Tested on platforms: N3K,N6K,N7K,N9K

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 24, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/network/nxos/nxos_pim.py:164:48: multiple-statements More than one statement on a single line

The test ansible-test sanity --test pep8 [explain] failed with 3 errors:

lib/ansible/modules/network/nxos/nxos_pim.py:164:47: E701 multiple statements on one line (colon)
lib/ansible/modules/network/nxos/nxos_pim.py:184:15: E111 indentation is not a multiple of four
lib/ansible/modules/network/nxos/nxos_pim.py:184:15: E117 over-indented

click here for bot help

@mikewiebe

This comment has been minimized.

Copy link
Contributor

commented May 30, 2019

LGTM

@ansibot ansibot added shipit and removed core_review labels May 30, 2019

@trishnaguha
Copy link
Member

left a comment

Please look at the comment #57425 (review)

@chrisvanheuveln chrisvanheuveln force-pushed the chrisvanheuveln:devel-nxos_pim-bfd branch from 0f9847b to 2e89aed Jun 17, 2019

@ansibot ansibot removed the stale_ci label Jun 17, 2019

@chrisvanheuveln

This comment has been minimized.

Copy link
Contributor Author

commented Jun 17, 2019

@trishnaguha T/F -> enable/disable changes are committed. Retested against all regression testbeds.

@mikewiebe

This comment has been minimized.

Copy link
Contributor

commented Jun 17, 2019

shipit

@trishnaguha trishnaguha merged commit 30830a4 into ansible:devel Jun 19, 2019

1 check passed

Shippable Run 128034 status is SUCCESS.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.