Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nmap add cache and constructor support and small fixes #56931

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
2 participants
@denngie
Copy link
Contributor

commented May 24, 2019

SUMMARY

Changes:

  • nmap inventory plugin now supports cache and constructor, docs already (falsely) indicated it
  • Require inventory file ending with .nmap.yml according to developer guide instructions
  • Removed old unneeded imports
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

nmap

ADDITIONAL INFORMATION

N/A

@denngie

This comment has been minimized.

Copy link
Contributor Author

commented May 24, 2019

Will this PR be in conflict with #56457 since they both modify the same part of this file (line 146)?

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 24, 2019

@denngie this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

cache support
unused variable from splitext

modernize file verification

add construct support

Fix cache logic

remove port if empty

remove unused imports

@denngie denngie force-pushed the denngie:nmap-cache-constructor-support branch from f454909 to 1f7ee3e May 24, 2019

@ansibot ansibot added the stale_ci label Jun 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.