Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding module for ibm dmgr #56945

Open
wants to merge 6 commits into
base: devel
from

Conversation

Projects
None yet
3 participants
@tdavison784
Copy link

commented May 25, 2019

SUMMARY

This merge is for adding a module for starting and stopping ibm dmgr profile. The module supports ansible-doc and ansible dry run. ibm_manager is an idempotent module.

No fixes for this merge. This is my first merge attempt.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

ibm_manager

ADDITIONAL INFORMATION

This PR is to merge in new code to the ansible project. This code is related to the IBM Websphere Application Server (WAS) Deployment manager profile. This module will take care of starting and stopping the Dmgr profile.

This module is one of many that will I will be attempting to merge into ansible to support full stack creation and management for IBM WAS platform.

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 25, 2019

The test ansible-test sanity --test pylint [explain] failed with 3 errors:

lib/ansible/modules/web_infrastructure/ibm_manager.py:88:16: bad-whitespace Exactly one space required after assignment     run_manager =  module.run_command(manager)                 ^
lib/ansible/modules/web_infrastructure/ibm_manager.py:90:23: bad-whitespace Exactly one space required after comparison     if  run_manager[0] !=  0:                        ^^
lib/ansible/modules/web_infrastructure/ibm_manager.py:166:28: bad-whitespace No space allowed around keyword argument assignment         supports_check_mode = True                             ^

The test ansible-test sanity --test boilerplate [explain] failed with 2 errors:

lib/ansible/modules/web_infrastructure/ibm_manager.py:0:0: missing: __metaclass__ = type
lib/ansible/modules/web_infrastructure/ibm_manager.py:0:0: missing: from __future__ import (absolute_import, division, print_function)

The test ansible-test sanity --test pep8 [explain] failed with 13 errors:

lib/ansible/modules/web_infrastructure/ibm_manager.py:86:60: E127 continuation line over-indented for visual indent
lib/ansible/modules/web_infrastructure/ibm_manager.py:87:60: E127 continuation line over-indented for visual indent
lib/ansible/modules/web_infrastructure/ibm_manager.py:88:18: E222 multiple spaces after operator
lib/ansible/modules/web_infrastructure/ibm_manager.py:90:7: E271 multiple spaces after keyword
lib/ansible/modules/web_infrastructure/ibm_manager.py:90:26: E222 multiple spaces after operator
lib/ansible/modules/web_infrastructure/ibm_manager.py:134:5: E303 too many blank lines (2)
lib/ansible/modules/web_infrastructure/ibm_manager.py:156:1: E101 indentation contains mixed spaces and tabs
lib/ansible/modules/web_infrastructure/ibm_manager.py:156:1: W191 indentation contains tabs
lib/ansible/modules/web_infrastructure/ibm_manager.py:157:1: E101 indentation contains mixed spaces and tabs
lib/ansible/modules/web_infrastructure/ibm_manager.py:166:28: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/web_infrastructure/ibm_manager.py:166:30: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/web_infrastructure/ibm_manager.py:173:5: E265 block comment should start with '# '
lib/ansible/modules/web_infrastructure/ibm_manager.py:174:5: E265 block comment should start with '# '

The test ansible-test sanity --test validate-modules [explain] failed with 6 errors:

lib/ansible/modules/web_infrastructure/ibm_manager.py:0:0: E307 version_added should be '2.9'. Currently '3.0'
lib/ansible/modules/web_infrastructure/ibm_manager.py:0:0: E319 RETURN.message.returned: required key not provided @ data['message']['returned']. Got None
lib/ansible/modules/web_infrastructure/ibm_manager.py:0:0: E319 RETURN.message.type: required key not provided @ data['message']['type']. Got None
lib/ansible/modules/web_infrastructure/ibm_manager.py:0:0: E319 RETURN.result.returned: required key not provided @ data['result']['returned']. Got None
lib/ansible/modules/web_infrastructure/ibm_manager.py:7:0: E106 Import found before documentation variables. All imports must appear below DOCUMENTATION/EXAMPLES/RETURN/ANSIBLE_METADATA.
lib/ansible/modules/web_infrastructure/ibm_manager.py:7:0: E107 Imports should be directly below DOCUMENTATION/EXAMPLES/RETURN/ANSIBLE_METADATA.

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 25, 2019

The test ansible-test sanity --test pylint [explain] failed with 3 errors:

lib/ansible/modules/web_infrastructure/ibm_manager.py:73:0: misplaced-future __future__ import is not the first non docstring statement
lib/ansible/modules/web_infrastructure/ibm_manager.py:84:14: too-few-format-args Not enough arguments for format string
lib/ansible/modules/web_infrastructure/ibm_manager.py:85:29: bad-whitespace Exactly one space required after comma     (module.params['profile'],module.params['state']))                              ^

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/web_infrastructure/ibm_manager.py:73:0: SyntaxError: from __future__ imports must occur at the beginning of the file

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/web_infrastructure/ibm_manager.py:73:0: SyntaxError: from __future__ imports must occur at the beginning of the file

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/web_infrastructure/ibm_manager.py:73:0: SyntaxError: from __future__ imports must occur at the beginning of the file

The test ansible-test sanity --test import --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/web_infrastructure/ibm_manager.py:73:0: SyntaxError: from __future__ imports must occur at the beginning of the file

The test ansible-test sanity --test import --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/web_infrastructure/ibm_manager.py:73:0: SyntaxError: from __future__ imports must occur at the beginning of the file

The test ansible-test sanity --test import --python 3.8 [explain] failed with 1 error:

lib/ansible/modules/web_infrastructure/ibm_manager.py:73:1: SyntaxError: from __future__ imports must occur at the beginning of the file

The test ansible-test sanity --test pep8 [explain] failed with 3 errors:

lib/ansible/modules/web_infrastructure/ibm_manager.py:77:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/web_infrastructure/ibm_manager.py:85:5: E128 continuation line under-indented for visual indent
lib/ansible/modules/web_infrastructure/ibm_manager.py:85:30: E231 missing whitespace after ','

The test ansible-test sanity --test validate-modules [explain] failed with 4 errors:

lib/ansible/modules/web_infrastructure/ibm_manager.py:0:0: E319 RETURN.message.returned: required key not provided @ data['message']['returned']. Got None
lib/ansible/modules/web_infrastructure/ibm_manager.py:0:0: E319 RETURN.message.type: required key not provided @ data['message']['type']. Got None
lib/ansible/modules/web_infrastructure/ibm_manager.py:0:0: E319 RETURN.result.returned: required key not provided @ data['result']['returned']. Got None
lib/ansible/modules/web_infrastructure/ibm_manager.py:0:0: E321 Exception attempting to import module for argument_spec introspection, 'from __future__ imports must occur at the beginning of the file (ibm_manager.py, line 73)'

click here for bot help

tdavison784 added some commits May 25, 2019

@ansibot ansibot removed the ci_verified label May 25, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 25, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 3 errors:

lib/ansible/modules/web_infrastructure/ibm_manager.py:0:0: E319 RETURN.message.returned: required key not provided @ data['message']['returned']. Got None
lib/ansible/modules/web_infrastructure/ibm_manager.py:0:0: E319 RETURN.message.type: required key not provided @ data['message']['type']. Got None
lib/ansible/modules/web_infrastructure/ibm_manager.py:0:0: E319 RETURN.result.returned: required key not provided @ data['result']['returned']. Got None

click here for bot help

@ansibot ansibot added the ci_verified label May 25, 2019

@ansibot ansibot removed the ci_verified label May 25, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 25, 2019

@nmajin

This comment has been minimized.

Copy link

commented May 30, 2019

I think this repo was heading in a good direction with IBM WebSphere modules, might want to give this a review: https://github.com/amimof/ansible-websphere

@tdavison784

This comment has been minimized.

Copy link
Author

commented May 30, 2019

@nmajin Thanks for the info, I have seen this repo before but at the time didn't appear to be to actively maintained. I have quite a few modules available for various IBM related tasks: https://github.com/tdavison784/ibmAnsibleModules

This is my first merge/contribution request so started with the ibm_dmgr module. Will the other existing repo have any interference with a possible merge of my available modules into ansible?

@tdavison784

This comment has been minimized.

Copy link
Author

commented May 31, 2019

Hi everyone,

Is there any more triage going on with this merge that I can assist with on my module end? Just want to keep this moving forward :)

@tdavison784

This comment has been minimized.

Copy link
Author

commented Jun 6, 2019

@nmajin Can I do anything to keep this moving forward? What are our current hold ups?

@ansibot ansibot added the stale_ci label Jun 6, 2019

@nmajin

This comment has been minimized.

Copy link

commented Jun 11, 2019

@nmajin Can I do anything to keep this moving forward? What are our current hold ups?

I don't have the option to merge this PR in, it will need to be one of the project owners I believe.

@tdavison784

This comment has been minimized.

Copy link
Author

commented Jun 21, 2019

Hey name space maintainers, any thing I can do to get this module merged into ansible-devel branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.