Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win_format - Add allocation_unit_size #56966

Open
wants to merge 6 commits into
base: devel
from

Conversation

Projects
None yet
4 participants
@chopraaa
Copy link
Contributor

commented May 26, 2019

SUMMARY

Fixes #56961

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

win_format

ADDITIONAL INFORMATION

Added allocation_unit_size support for win_format. Was added initially then removed after the re-write. Putting it back in with this.

Added a note in the docs to specify usage of physical sector size as well.

@ansibot

This comment has been minimized.

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 28, 2019

@ShachafGoldstein

This comment has been minimized.

Copy link
Contributor

commented May 28, 2019

Seems the allocation_unit_zise is never set with a default value since it is now being used it should have a default value or not sent to Format-volume if null

@chopraaa

This comment has been minimized.

Copy link
Contributor Author

commented May 29, 2019

It's not sent to Format-Volume if it's null.

@ShachafGoldstein

This comment has been minimized.

Copy link
Contributor

commented May 29, 2019

It's not sent to Format-Volume if it's null.
Right, missed that.

Maybe you should add a test for this in test/integration/targets/win_format/tasks/tests.yml

@ShachafGoldstein

This comment has been minimized.

Copy link
Contributor

commented Jun 2, 2019

It's not sent to Format-Volume if it's null.

Right, missed that

Can you add a bug fix changelog fragment?

@chopraaa

This comment has been minimized.

Copy link
Contributor Author

commented Jun 3, 2019

Maybe you should add a test for this in test/integration/targets/win_format/tasks/tests.yml

Sure. I've had a tight week so this might take an additional 1-2 days.

Can you add a bug fix changelog fragment?

Not sure how to do this but I'll look this up.

@ansibot ansibot added the stale_ci label Jun 3, 2019

@chopraaa chopraaa changed the title win_format - Add allocation_unit_size WIP win_format - Add allocation_unit_size Jun 3, 2019

@ansibot ansibot added the WIP label Jun 4, 2019

chopraaa added some commits Jun 22, 2019

@chopraaa chopraaa changed the title WIP win_format - Add allocation_unit_size win_format - Add allocation_unit_size Jun 22, 2019

@ansibot ansibot added needs_revision and removed core_review labels Jun 22, 2019

chopraaa added some commits Jun 22, 2019

@ansibot ansibot added core_review and removed needs_revision labels Jun 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.