Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win_domain_computer module: Fix idempotence when name != sam_account_name #56967

Conversation

Projects
None yet
6 participants
@Daniel-Sanchez-Fabregas
Copy link
Contributor

commented May 26, 2019

SUMMARY

Creating a computer with distinct name and sam_account_name makes idempotence fail.
Running the test provided test/integration/targets/win_domain_computer/tasks/main.yml (tried to follow the examples but surely will need adaptations) shows the mentioned idempotence fail.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

win_domain_computer

ADDITIONAL INFORMATION

Inside the module we ask for the AD computer object by sam_account_name instead of name, fixing the issue.

@ansibot

This comment has been minimized.

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 26, 2019

The test ansible-test sanity --test integration-aliases [explain] failed with 1 error:

test/integration/targets/win_domain_computer/aliases:0:0: missing alias `shippable/windows/group[1-6]` or `unsupported`

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.