Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds visibility parameter to gitlab group creation #57024

Merged
merged 1 commit into from Jun 13, 2019

Conversation

Projects
None yet
4 participants
@Skybound1
Copy link
Contributor

commented May 27, 2019

SUMMARY

Adds visibility as a parameter to gitlab group creation

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

gitlab_group

ADDITIONAL INFORMATION

The visibility parameter was not being used when a group is being created, only when a group was getting updated. This patch adds it into the group creation as well. The following ansible created a group with private visibility settings before the patch, and public visibility after the patch.

- name: Add website group
  gitlab_group:
    server_url: URL
    login_token: TOKEN
    name: example_group
    visibility: public
@ansibot

This comment has been minimized.

@Lunik

This comment has been minimized.

Copy link
Contributor

commented May 28, 2019

shipit

@ansibot ansibot removed the needs_triage label May 28, 2019

@Skybound1

This comment has been minimized.

Copy link
Contributor Author

commented May 28, 2019

I ran across this when using 2.8, is it possible to get this pushed out as part of a minor version of 2.8?

@Skybound1

This comment has been minimized.

Copy link
Contributor Author

commented Jun 2, 2019

Is there an update to this?

@Shaps

This comment has been minimized.

Copy link
Contributor

commented Jun 9, 2019

shipit

@ansibot ansibot merged commit e7bf46d into ansible:devel Jun 13, 2019

1 check passed

Shippable Run 127484 status is SUCCESS.
Details

Lunik pushed a commit to Lunik/ansible that referenced this pull request Jun 14, 2019

@Lunik Lunik referenced this pull request Jun 14, 2019

Merged

Backport/2.8/57024 #57846

Lunik added a commit to Lunik/ansible that referenced this pull request Jun 14, 2019

abadger added a commit that referenced this pull request Jun 18, 2019

Backport/2.8/57024 (#57846)
* Adds visibility parameter to gitlab group creation (#57024)

(cherry picked from commit e7bf46d)

* Add changelog for backport/2.8/57024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.