Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename xenserver_guest_facts -> xenserver_guest_info #57032

Open
wants to merge 3 commits into
base: devel
from

Conversation

Projects
None yet
4 participants
@felixfontein
Copy link
Contributor

commented May 28, 2019

SUMMARY

Continues #56822. The modules do not return ansible_facts.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

xenserver_guest_facts

@felixfontein felixfontein force-pushed the felixfontein:facts-info-xenserver branch from db0f5f4 to cb204f9 May 28, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 28, 2019

@felixfontein

This comment has been minimized.

Copy link
Contributor Author

commented May 28, 2019

FYI: this PR includes no new module, it renames a module.

@felixfontein felixfontein force-pushed the felixfontein:facts-info-xenserver branch from c4ca114 to 3b6c0a4 May 28, 2019

@bvitnik

This comment has been minimized.

Copy link
Contributor

commented May 28, 2019

This change will pretty much screw up one of my currently pending PRs: #56242. I'd like it to be merged first, before we do rename _facts -> _info. I'm expecting @mattclay to review it sometime this week. I can do rename of _facts -> _info myself later... if needed.

@ansibot ansibot removed the needs_triage label May 28, 2019

@felixfontein

This comment has been minimized.

Copy link
Contributor Author

commented May 28, 2019

@bvitnik sure, totally fine for me :) Feel free to salvage this PR in case you want to rename the module by yourself. Ping me when that PR is merged (if you want me to rename the module) or ping me in the rename PR (if you want to create one).

@bvitnik

This comment has been minimized.

Copy link
Contributor

commented May 28, 2019

@felixfontein No problem.

@anshulbehl
Copy link

left a comment

Just checked to see if there are docs related errors, HTML pages built fine.

@felixfontein felixfontein force-pushed the felixfontein:facts-info-xenserver branch from 3b6c0a4 to 5ab52b6 May 29, 2019

@felixfontein

This comment has been minimized.

Copy link
Contributor Author

commented May 29, 2019

(Rebased to remove conflict.)

@felixfontein felixfontein force-pushed the felixfontein:facts-info-xenserver branch from 5ab52b6 to ac10cb0 Jun 6, 2019

@felixfontein felixfontein force-pushed the felixfontein:facts-info-xenserver branch from ac10cb0 to c5101d6 Jun 10, 2019

@felixfontein felixfontein force-pushed the felixfontein:facts-info-xenserver branch from c5101d6 to 9f8cea0 Jun 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.