Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apcon modules #57079

Open
wants to merge 4 commits into
base: devel
from

Conversation

@davidlee-ap
Copy link

commented May 28, 2019

SUMMARY

Add new modules to support APCON network devices

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

lib/modules/network/apconos
lib/module_utils/network/apconos
lib/plugins/action/apconos_config.py
lib/plugins/action/apconos.py
lib/plugins/cliconf/apconos.py
lib/plugins/terminal/apconos.py

ADDITIONAL INFORMATION

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 28, 2019

The test ansible-test sanity --test pylint [explain] failed with 10 errors:

lib/ansible/module_utils/network/apconos/apconos.py:110:4: undefined-variable Undefined variable 'cmd'
lib/ansible/module_utils/network/apconos/apconos.py:156:0: trailing-newlines Trailing newlines
lib/ansible/modules/network/apconos/apconos_cert.py:75:82: trailing-whitespace Trailing whitespace
lib/ansible/modules/network/apconos/apconos_cert.py:78:0: ansible-bad-module-import Import external package or ansible.module_utils not ansible.utils.display
lib/ansible/modules/network/apconos/apconos_cert.py:98:18: trailing-whitespace Trailing whitespace
lib/ansible/modules/network/apconos/apconos_cert.py:120:20: undefined-variable Undefined variable 'Conditional'
lib/ansible/modules/network/apconos/apconos_update.py:92:82: trailing-whitespace Trailing whitespace
lib/ansible/modules/network/apconos/apconos_update.py:95:0: ansible-bad-module-import Import external package or ansible.module_utils not ansible.utils.display
lib/ansible/modules/network/apconos/apconos_update.py:140:18: trailing-whitespace Trailing whitespace
lib/ansible/modules/network/apconos/apconos_update.py:165:20: undefined-variable Undefined variable 'Conditional'

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/plugins/terminal/apconos.py:38:0: trailing-newlines Trailing newlines

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 3 errors:

lib/ansible/modules/network/apconos/apconos_command.py:0:0: has a documentation error formatting or is missing documentation.
lib/ansible/modules/network/apconos/apconos_update.py:0:0: has a documentation error formatting or is missing documentation.
lib/ansible/plugins/cliconf/apconos.py:0:0: missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 3 errors:

lib/ansible/modules/network/apconos/apconos_command.py:0:0: has a documentation error formatting or is missing documentation.
lib/ansible/modules/network/apconos/apconos_update.py:0:0: has a documentation error formatting or is missing documentation.
lib/ansible/plugins/cliconf/apconos.py:0:0: missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 3 errors:

lib/ansible/modules/network/apconos/apconos_command.py:0:0: has a documentation error formatting or is missing documentation.
lib/ansible/modules/network/apconos/apconos_update.py:0:0: has a documentation error formatting or is missing documentation.
lib/ansible/plugins/cliconf/apconos.py:0:0: missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 3 errors:

lib/ansible/modules/network/apconos/apconos_command.py:0:0: has a documentation error formatting or is missing documentation.
lib/ansible/modules/network/apconos/apconos_update.py:0:0: has a documentation error formatting or is missing documentation.
lib/ansible/plugins/cliconf/apconos.py:0:0: missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 3 errors:

lib/ansible/modules/network/apconos/apconos_command.py:0:0: has a documentation error formatting or is missing documentation.
lib/ansible/modules/network/apconos/apconos_update.py:0:0: has a documentation error formatting or is missing documentation.
lib/ansible/plugins/cliconf/apconos.py:0:0: missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 3.8 [explain] failed with 3 errors:

lib/ansible/modules/network/apconos/apconos_command.py:0:0: has a documentation error formatting or is missing documentation.
lib/ansible/modules/network/apconos/apconos_update.py:0:0: has a documentation error formatting or is missing documentation.
lib/ansible/plugins/cliconf/apconos.py:0:0: missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test docs-build [explain] failed with the error:

Command "/usr/bin/python3.6 test/sanity/code-smell/docs-build.py" returned exit status 1.
>>> Standard Error
Command 'make singlehtmldocs' failed with status code: 2
--> Standard Output
PYTHONPATH=../../lib ../bin/dump_config.py --template-file=../templates/config.rst.j2 --output-dir=rst/reference_appendices/ -d ../../lib/ansible/config/base.yml
mkdir -p rst/cli
PYTHONPATH=../../lib ../bin/generate_man.py --template-file=../templates/cli_rst.j2 --output-dir=rst/cli/ --output-format rst ../../lib/ansible/cli/*.py
PYTHONPATH=../../lib ../bin/dump_keywords.py --template-dir=../templates --output-dir=rst/reference_appendices/ -d ./keyword_desc.yml
PYTHONPATH=../../lib ../bin/plugin_formatter.py -t rst --template-dir=../templates --module-dir=../../lib/ansible/modules -o rst/modules/ 
Evaluating module files...
Makefile:93: recipe for target 'modules' failed
--> Standard Error
Traceback (most recent call last):
  File "../bin/plugin_formatter.py", line 813, in <module>
    main()
  File "../bin/plugin_formatter.py", line 768, in main
    plugin_info, categories = get_plugin_info(options.module_dir, limit_to=options.limit_to, verbose=(options.verbosity > 0))
  File "../bin/plugin_formatter.py", line 298, in get_plugin_info
    doc, examples, returndocs, metadata = plugin_docs.get_docstring(module_path, fragment_loader, verbose=verbose)
  File "/root/ansible/lib/ansible/utils/plugin_docs.py", line 111, in get_docstring
    data = read_docstring(filename, verbose=verbose, ignore_errors=ignore_errors)
  File "/root/ansible/lib/ansible/parsing/plugin_docs.py", line 59, in read_docstring
    data[varkey] = AnsibleLoader(child.value.s, file_name=filename).get_single_data()
  File "/usr/local/lib/python3.6/dist-packages/yaml/constructor.py", line 41, in get_single_data
    node = self.get_single_node()
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 36, in get_single_node
    document = self.compose_document()
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 55, in compose_document
    node = self.compose_node(None, None)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 84, in compose_node
    node = self.compose_mapping_node(anchor)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 133, in compose_mapping_node
    item_value = self.compose_node(node, item_key)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 84, in compose_node
    node = self.compose_mapping_node(anchor)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 133, in compose_mapping_node
    item_value = self.compose_node(node, item_key)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 84, in compose_node
    node = self.compose_mapping_node(anchor)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 133, in compose_mapping_node
    item_value = self.compose_node(node, item_key)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 82, in compose_node
    node = self.compose_sequence_node(anchor)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 110, in compose_sequence_node
    while not self.check_event(SequenceEndEvent):
  File "/usr/local/lib/python3.6/dist-packages/yaml/parser.py", line 98, in check_event
    self.current_event = self.state()
  File "/usr/local/lib/python3.6/dist-packages/yaml/parser.py", line 382, in parse_block_sequence_entry
    if self.check_token(BlockEntryToken):
  File "/usr/local/lib/python3.6/dist-packages/yaml/scanner.py", line 116, in check_token
    self.fetch_more_tokens()
  File "/usr/local/lib/python3.6/dist-packages/yaml/scanner.py", line 223, in fetch_more_tokens
    return self.fetch_value()
  File "/usr/local/lib/python3.6/dist-packages/yaml/scanner.py", line 579, in fetch_value
    self.get_mark())
yaml.scanner.ScannerError: mapping values are not allowed here
  in "<unicode string>", line 21, column 16:
            default: all
                   ^
make: *** [modules] Error 1

The test ansible-test sanity --test action-plugin-docs [explain] failed with 2 errors:

lib/ansible/plugins/action/apconos.py:0:0: action plugin has no matching module to provide documentation
lib/ansible/plugins/action/apconos_config.py:0:0: action plugin has no matching module to provide documentation

The test ansible-test sanity --test boilerplate [explain] failed with 6 errors:

lib/ansible/modules/network/apconos/apconos_cert.py:0:0: missing: __metaclass__ = type
lib/ansible/modules/network/apconos/apconos_cert.py:0:0: missing: from __future__ import (absolute_import, division, print_function)
lib/ansible/modules/network/apconos/apconos_command.py:0:0: missing: __metaclass__ = type
lib/ansible/modules/network/apconos/apconos_command.py:0:0: missing: from __future__ import (absolute_import, division, print_function)
lib/ansible/modules/network/apconos/apconos_update.py:0:0: missing: __metaclass__ = type
lib/ansible/modules/network/apconos/apconos_update.py:0:0: missing: from __future__ import (absolute_import, division, print_function)

The test ansible-test sanity --test import --python 2.6 [explain] failed with 2 errors:

lib/ansible/module_utils/network/apconos/apconos.py:39:0: ImportError: cannot import name return_values
test/runner/.tox/import/lib/ansible/module_utils/network/apconos/apconos.py:39:0: ImportError: cannot import name return_values

The test ansible-test sanity --test import --python 2.7 [explain] failed with 5 errors:

lib/ansible/module_utils/network/apconos/apconos.py:39:0: ImportError: cannot import name return_values
lib/ansible/modules/network/apconos/apconos_cert.py:75:0: ImportError: cannot import name return_values
lib/ansible/modules/network/apconos/apconos_command.py:112:0: ImportError: cannot import name return_values
lib/ansible/modules/network/apconos/apconos_update.py:92:0: ImportError: cannot import name return_values
test/runner/.tox/import/lib/ansible/module_utils/network/apconos/apconos.py:39:0: ImportError: cannot import name return_values

The test ansible-test sanity --test import --python 3.5 [explain] failed with 5 errors:

lib/ansible/module_utils/network/apconos/apconos.py:39:0: ImportError: cannot import name 'return_values'
lib/ansible/modules/network/apconos/apconos_cert.py:75:0: ImportError: cannot import name 'return_values'
lib/ansible/modules/network/apconos/apconos_command.py:112:0: ImportError: cannot import name 'return_values'
lib/ansible/modules/network/apconos/apconos_update.py:92:0: ImportError: cannot import name 'return_values'
test/runner/.tox/import/lib/ansible/module_utils/network/apconos/apconos.py:39:0: ImportError: cannot import name 'return_values'

The test ansible-test sanity --test import --python 3.6 [explain] failed with 5 errors:

lib/ansible/module_utils/network/apconos/apconos.py:39:0: ImportError: cannot import name 'return_values'
lib/ansible/modules/network/apconos/apconos_cert.py:75:0: ImportError: cannot import name 'return_values'
lib/ansible/modules/network/apconos/apconos_command.py:112:0: ImportError: cannot import name 'return_values'
lib/ansible/modules/network/apconos/apconos_update.py:92:0: ImportError: cannot import name 'return_values'
test/runner/.tox/import/lib/ansible/module_utils/network/apconos/apconos.py:39:0: ImportError: cannot import name 'return_values'

The test ansible-test sanity --test import --python 3.7 [explain] failed with 5 errors:

lib/ansible/module_utils/network/apconos/apconos.py:39:0: ImportError: cannot import name 'return_values' from 'ansible.module_utils.basic' (/root/ansible/test/runner/.tox/import/lib/ansible/module_utils/basic.py)
lib/ansible/modules/network/apconos/apconos_cert.py:75:0: ImportError: cannot import name 'return_values' from 'ansible.module_utils.basic' (/root/ansible/test/runner/.tox/import/lib/ansible/module_utils/basic.py)
lib/ansible/modules/network/apconos/apconos_command.py:112:0: ImportError: cannot import name 'return_values' from 'ansible.module_utils.basic' (/root/ansible/test/runner/.tox/import/lib/ansible/module_utils/basic.py)
lib/ansible/modules/network/apconos/apconos_update.py:92:0: ImportError: cannot import name 'return_values' from 'ansible.module_utils.basic' (/root/ansible/test/runner/.tox/import/lib/ansible/module_utils/basic.py)
test/runner/.tox/import/lib/ansible/module_utils/network/apconos/apconos.py:39:0: ImportError: cannot import name 'return_values' from 'ansible.module_utils.basic' (/root/ansible/test/runner/.tox/import/lib/ansible/module_utils/basic.py)

The test ansible-test sanity --test import --python 3.8 [explain] failed with 5 errors:

lib/ansible/module_utils/network/apconos/apconos.py:39:0: ImportError: cannot import name 'return_values' from 'ansible.module_utils.basic' (/root/ansible/test/runner/.tox/import/lib/ansible/module_utils/basic.py)
lib/ansible/modules/network/apconos/apconos_cert.py:75:0: ImportError: cannot import name 'return_values' from 'ansible.module_utils.basic' (/root/ansible/test/runner/.tox/import/lib/ansible/module_utils/basic.py)
lib/ansible/modules/network/apconos/apconos_command.py:112:0: ImportError: cannot import name 'return_values' from 'ansible.module_utils.basic' (/root/ansible/test/runner/.tox/import/lib/ansible/module_utils/basic.py)
lib/ansible/modules/network/apconos/apconos_update.py:92:0: ImportError: cannot import name 'return_values' from 'ansible.module_utils.basic' (/root/ansible/test/runner/.tox/import/lib/ansible/module_utils/basic.py)
test/runner/.tox/import/lib/ansible/module_utils/network/apconos/apconos.py:39:0: ImportError: cannot import name 'return_values' from 'ansible.module_utils.basic' (/root/ansible/test/runner/.tox/import/lib/ansible/module_utils/basic.py)

The test ansible-test sanity --test pep8 [explain] failed with 31 errors:

lib/ansible/module_utils/network/apconos/apconos.py:122:1: E302 expected 2 blank lines, found 1
lib/ansible/module_utils/network/apconos/apconos.py:135:1: E302 expected 2 blank lines, found 1
lib/ansible/module_utils/network/apconos/apconos.py:143:1: E302 expected 2 blank lines, found 1
lib/ansible/module_utils/network/apconos/apconos.py:156:1: W391 blank line at end of file
lib/ansible/modules/network/apconos/apconos_cert.py:75:83: W291 trailing whitespace
lib/ansible/modules/network/apconos/apconos_cert.py:82:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/network/apconos/apconos_cert.py:88:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/network/apconos/apconos_cert.py:91:5: E265 block comment should start with '# '
lib/ansible/modules/network/apconos/apconos_cert.py:95:73: E226 missing whitespace around arithmetic operator
lib/ansible/modules/network/apconos/apconos_cert.py:98:19: W291 trailing whitespace
lib/ansible/modules/network/apconos/apconos_cert.py:100:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/network/apconos/apconos_cert.py:127:5: E303 too many blank lines (2)
lib/ansible/modules/network/apconos/apconos_update.py:18:68: W291 trailing whitespace
lib/ansible/modules/network/apconos/apconos_update.py:23:59: W291 trailing whitespace
lib/ansible/modules/network/apconos/apconos_update.py:24:60: W291 trailing whitespace
lib/ansible/modules/network/apconos/apconos_update.py:92:83: W291 trailing whitespace
lib/ansible/modules/network/apconos/apconos_update.py:99:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/network/apconos/apconos_update.py:105:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/network/apconos/apconos_update.py:117:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/network/apconos/apconos_update.py:127:22: E126 continuation line over-indented for hanging indent
lib/ansible/modules/network/apconos/apconos_update.py:128:5: E265 block comment should start with '# '
lib/ansible/modules/network/apconos/apconos_update.py:131:9: E265 block comment should start with '# '
lib/ansible/modules/network/apconos/apconos_update.py:133:9: E265 block comment should start with '# '
lib/ansible/modules/network/apconos/apconos_update.py:136:22: E126 continuation line over-indented for hanging indent
lib/ansible/modules/network/apconos/apconos_update.py:136:29: E222 multiple spaces after operator
lib/ansible/modules/network/apconos/apconos_update.py:137:5: E265 block comment should start with '# '
lib/ansible/modules/network/apconos/apconos_update.py:140:19: W291 trailing whitespace
lib/ansible/modules/network/apconos/apconos_update.py:142:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/network/apconos/apconos_update.py:157:9: E123 closing bracket does not match indentation of opening bracket's line
lib/ansible/plugins/terminal/apconos.py:30:7: E121 continuation line under-indented for hanging indent
lib/ansible/plugins/terminal/apconos.py:38:1: W391 blank line at end of file

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 28, 2019

@davidlee-ap this PR contains more than one new module.

Please submit only one new module per pull request. For a detailed explanation, please read the grouped modules documentation

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 28, 2019

@davidlee-ap, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 29, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 29, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 15 errors:

lib/ansible/modules/network/apconos/apconos_cert.py:0:0: E322 Argument 'command' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/apconos/apconos_cert.py:0:0: E322 Argument 'provider' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/apconos/apconos_cert.py:76:17: E311 EXAMPLES is not valid YAML
lib/ansible/modules/network/apconos/apconos_command.py:0:0: E322 Argument 'provider' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/apconos/apconos_command.py:89:1: E311 EXAMPLES is not valid YAML
lib/ansible/modules/network/apconos/apconos_config.py:0:0: E305 DOCUMENTATION.description: required key not provided @ data['description']. Got None
lib/ansible/modules/network/apconos/apconos_update.py:0:0: E319 RETURN.current version.type: required key not provided @ data['current version']['type']. Got None
lib/ansible/modules/network/apconos/apconos_update.py:0:0: E319 RETURN.stdout.type: required key not provided @ data['stdout']['type']. Got None
lib/ansible/modules/network/apconos/apconos_update.py:0:0: E319 RETURN.stdout_lines.type: required key not provided @ data['stdout_lines']['type']. Got None
lib/ansible/modules/network/apconos/apconos_update.py:0:0: E322 Argument 'provider' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/apconos/apconos_update.py:0:0: E322 Argument 'version' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/apconos/apconos_update.py:0:0: E324 Argument 'blade_letter' in argument_spec defines default as (['A']) but documentation defines default as (None)
lib/ansible/modules/network/apconos/apconos_update.py:0:0: E324 Argument 'device' in argument_spec defines default as (None) but documentation defines default as (['all'])
lib/ansible/modules/network/apconos/apconos_update.py:0:0: E326 Argument 'device' in argument_spec defines choices as ([]) but documentation defines choices as ([['all'], ['blade']])
lib/ansible/modules/network/apconos/apconos_update.py:92:19: E311 EXAMPLES is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 3 errors:

lib/ansible/modules/network/apconos/apconos_cert.py:76:17: error EXAMPLES: syntax error: mapping values are not allowed here
lib/ansible/modules/network/apconos/apconos_command.py:89:1: error EXAMPLES: syntax error: expected <block end>, but found '-'
lib/ansible/modules/network/apconos/apconos_update.py:92:19: error EXAMPLES: syntax error: mapping values are not allowed here

click here for bot help

Dismissing out-of-date review.

DOCUMENTATION = """
---
module: apconos_cert
version_added: "2.9.0"

This comment has been minimized.

Copy link
@kbreit

kbreit May 30, 2019

Contributor

It could also be 2.9 as no new modules are added on minor releases.

This comment has been minimized.

Copy link
@davidlee-ap

davidlee-ap May 30, 2019

Author

I'll fix it!
Thanks!

author: "David Lee (@davidlee-ap)"
short_description: install ssl ipv4 certificate on apcon network devices
description:
- import and install ssl ipv4 certificate with specifying remote filename

This comment has been minimized.

Copy link
@kbreit

kbreit May 30, 2019

Contributor

Capitalize properly

This comment has been minimized.

Copy link
@davidlee-ap

davidlee-ap May 30, 2019

Author

I'll fix it.
Thanks!

module: apconos_cert
version_added: "2.9.0"
author: "David Lee (@davidlee-ap)"
short_description: install ssl ipv4 certificate on apcon network devices

This comment has been minimized.

Copy link
@kbreit

kbreit May 30, 2019

Contributor

Capitalize properly

This comment has been minimized.

Copy link
@davidlee-ap

davidlee-ap May 30, 2019

Author

I'll fix it. Thanks!

options:
command:
description:
- currently it is not being used in apconos_cert module.

This comment has been minimized.

Copy link
@kbreit

kbreit May 30, 2019

Contributor

Why is it here then?

This comment has been minimized.

Copy link
@davidlee-ap

davidlee-ap May 30, 2019

Author

Sanity test couldn't pass without it. It might be implemented in the future.

This comment has been minimized.

Copy link
@mattclay

mattclay May 30, 2019

Member

If it's not used by the module, remove it from the module spec instead of adding it to the docs.

This comment has been minimized.

Copy link
@davidlee-ap

davidlee-ap May 31, 2019

Author

I'll remove it.
Thanks!

retries=dict(default=10, type='int'),
interval=dict(default=1, type='int'),

ipaddress=dict(type='list'),

This comment has been minimized.

Copy link
@kbreit

kbreit May 30, 2019

Contributor

Why would this be a list instead of a str? Also, other modules normally use camel case. I'll defer to a core developer to see what they think about this convention.

This comment has been minimized.

Copy link
@davidlee-ap

davidlee-ap May 30, 2019

Author

str should be OK, but it is supposed to be a list for the application.

This comment has been minimized.

Copy link
@kbreit

kbreit May 30, 2019

Contributor

What do you mean? How is this interfacing and what’s the application?

This comment has been minimized.

Copy link
@mattclay

mattclay May 30, 2019

Member

The module is only using ipaddress[0], so this shouldn't be a list.

This comment has been minimized.

Copy link
@davidlee-ap

davidlee-ap May 31, 2019

Author

The module is only using ipaddress[0], so this shouldn't be a list.

I'll fix it.
Thanks!


spec.update(apconos_argument_spec)

module = AnsibleModule(argument_spec=spec, supports_check_mode=True)

This comment has been minimized.

Copy link
@kbreit

kbreit May 30, 2019

Contributor

Do you have anywhere in your code that's supporting check mode?

@@ -0,0 +1,108 @@
# Copyright (C) 2017 APCON.

This comment has been minimized.

Copy link
@kbreit

kbreit May 30, 2019

Contributor

Copyright is old.

This comment has been minimized.

Copy link
@davidlee-ap

davidlee-ap May 30, 2019

Author

I'll fix it. Thanks!

@danielmellado

This comment has been minimized.

Copy link
Contributor

commented Jun 6, 2019

It'd be also great to have integration and unit tests. You can check for example /ansible/ansible/tree/devel/test/units/modules/network

@ansibot ansibot added the stale_ci label Jun 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.