Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Port Security Timeout option in Interface Policy Port Security #57108

Open
wants to merge 4 commits into
base: devel
from

Conversation

Projects
None yet
2 participants
@fadallar
Copy link

commented May 29, 2019

SUMMARY

Add support for port security timeout for ACI Interface Policy Port Security

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

Network Module ACI
Library : _aci_intf_policy_port_security

ADDITIONAL INFORMATION

  • aci_interface_policy_port_security:
    host: '{{ inventory_hostname }}'
    username: '{{ username }}'
    password: '{{ password }}'
    port_security: '{{ port_security }}'
    description: '{{ descr }}'
    max_end_points: '{{ max_end_points }}'
    port_security_timeout: '{{ port_security_timeout }}' . <-- New option added
    delegate_to: localhost

fadallar added some commits May 29, 2019

Adding support for port security timeout attribute for ACI Interface …
…Policy Port Security

- Feature Pull Request

Network Module ACI

lib:  _aci_intf_policy_port_security.py
@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 29, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/network/aci/aci_interface_policy_port_security.py:207:82: bad-whitespace Exactly one space required after comma     if port_security_timeout is not None and port_security_timeout not in range(60,3601):                                                                                   ^

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/network/aci/aci_interface_policy_port_security.py:207:83: E231 missing whitespace after ','

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/network/aci/aci_interface_policy_port_security.py:0:0: E309 version_added for new option (port_security_timeout) should be '2.9'. Currently StrictVersion ('0.0')

click here for bot help

Fixing errors raised by ansible-test sanity test
pylint error E321 missing whitespace after comma

Added version 2.9 as version_added

@ansibot ansibot removed the ci_verified label May 29, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 29, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 2 errors:

lib/ansible/modules/network/aci/aci_interface_policy_port_security.py:0:0: E307 version_added should be '2.4'. Currently '2.9'
lib/ansible/modules/network/aci/aci_interface_policy_port_security.py:0:0: E309 version_added for new option (port_security_timeout) should be '2.9'. Currently StrictVersion ('0.0')

click here for bot help

@ansibot ansibot added the ci_verified label May 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.