Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
s3_bucket: add check mode support #57112
@catcombo, could you please have a go at the integration tests? I believe that it shouldn't be too complicated...
From what I've gathered after having a glance at the linked directory, you just need to go into tasks subdirectory and duplicate mutating blocks so that they come first and feature
Code looks good, and I agree having tests would be nice.
Exactly. I'm not sure how the AWS tests currently look like, but the "optimal" pattern is to do every thing four times:
(The order of 3 and 4 can of course be swapped.)
If idempotence checks aren't there yet, I would just add 1) and leave 3)+4) for later. (Except if you have time - idempotence checks are always good to have!)
Jun 2, 2019
There are a couple of tests which don't have check mode pendants:
Is this intentional?