Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VMware: Updates the DRS rule without deletion #57119

Open
wants to merge 4 commits into
base: devel
from

Conversation

Projects
None yet
3 participants
@Sunilrajj
Copy link

commented May 29, 2019

The DRS rule will be updated if any changes in the configuration without deleting the existing rule.
The rule itself is updated by the given configuration.

SUMMARY

The DRS rule will be updated to the new given configuration if the STATE is present
and the DRS rule already exists. There will be no deletion of the DRS rule. The rule will be updated
directly.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

vmware_vm_vm_drs_rule

ADDITIONAL INFORMATION

The given list of VMs will override the VMs list in the DRS rule provided. So to update the DRS rule,
provide with the existing VMs in the list along with the new VMs to add.


Updates the DRS rule without deletion
The DRS rule will be updated if any changes in the configuration without deleting the existing rule.
The rule itself is updated by the given configuration.
@ansibot

This comment has been minimized.

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 29, 2019

@Sunilrajj, just so you are aware we have a dedicated Working Group for vmware.
You can find other people interested in this in #ansible-vmware on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@Akasurde Akasurde changed the title Updates the DRS rule without deletion VMware: Updates the DRS rule without deletion May 29, 2019

@Akasurde Akasurde removed the needs_triage label May 29, 2019

@Akasurde
Copy link
Member

left a comment

Could you please write an integration test for this change ? Thanks.

@Sunilrajj

This comment has been minimized.

Copy link
Author

commented May 29, 2019

Need time for Integration Testing

VMware: update vmware_vm_vm_drs_rule testcases
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@Akasurde

This comment has been minimized.

Copy link
Member

commented May 29, 2019

Need time for Integration Testing

@Sunilrajj I created a PR Sunilrajj#1 please merge to update the testcase here. Thanks.

@Akasurde Akasurde requested review from goneri and jillr May 29, 2019

Merge pull request #1 from Akasurde/vm_drs_rule_update
VMware: update vmware_vm_vm_drs_rule testcases
@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 30, 2019

@Sunilrajj this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.