Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed os_user_role get_group and add new module os_group_facts #57120

Open
wants to merge 3 commits into
base: devel
from

Conversation

Projects
None yet
3 participants
@phsmith
Copy link

commented May 29, 2019

SUMMARY

Added new module named os_group_facts, based on os_project_facts, to retrieve groups data.
Fixed os_user_role module problem that didn't validate groups correctly.

ISSUE TYPE
  • Bugfix Pull Request
  • New Module Pull Request
COMPONENT NAME

os_project_facts

phsmith and others added some commits May 28, 2019

@phsmith phsmith changed the title Fix os_user_role get_group and add new module os_group_facts Fixed os_user_role get_group and add new module os_group_facts May 29, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 29, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/cloud/openstack/os_group_facts.py:130:12: bare-except No exception type(s) specified

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/openstack/os_group_facts.py:130:13: E722 do not use bare 'except'

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/openstack/os_group_facts.py:0:0: E307 version_added should be '2.9'. Currently '2.1'

click here for bot help

@ansibot ansibot removed the ci_verified label May 29, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 29, 2019

@SamYaple @agireud @albertomurillo @bennojoy @cloudnull @dagnello @dguerri @evrardjp @flwang @gtema @haneefs @ioggstream @juliakreger @Kong @kuboj @lingxiankong @matbu @mgale @mnaser @odyssey4me @omgjlk @ruizink @steveb

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@opendev-zuul

This comment has been minimized.

Copy link

commented May 29, 2019

Build succeeded (third-party-check pipeline).

EXAMPLES = '''
# Gather facts about previously created groups
- os_group_facts:
cloud: awesomecloud

This comment has been minimized.

Copy link
@cloudnull

cloudnull Jun 3, 2019

Contributor

do these example tasks need a "register"?

This comment has been minimized.

Copy link
@phsmith

phsmith Jun 3, 2019

Author

@cloudnull Sorry for the late answer.
No, this module don't need a register, It returns a variable named "openstack_groups".

@ansibot ansibot removed the needs_triage label Jun 3, 2019

@ansibot ansibot added the stale_ci label Jun 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.