Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ospf modules to fix bugs as software version changes (#56974) #57170

Open
wants to merge 2 commits into
base: stable-2.8
from

Conversation

Projects
None yet
3 participants
@xuxiaowei0512
Copy link
Contributor

commented May 30, 2019

(cherry picked from commit b7f4e2a)

SUMMARY

update ospf modules to fix bugs as software version changes

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/modules/network/cloudengine/ce_ospf.py
lib/ansible/modules/network/cloudengine/ce_ospf_vrf.py

ADDITIONAL INFORMATION

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 30, 2019

@ansibot ansibot removed the owner_pr label May 30, 2019

@abadger

This comment has been minimized.

Copy link
Member

commented May 30, 2019

Does there need to be compatibility for both patterns? That would be needed if people can be running different versions of this service (similar to openshift). The current PR is fine if this is all centrally managed (like AWS).

@ansibot ansibot removed the needs_triage label May 30, 2019

@xuxiaowei0512

This comment has been minimized.

Copy link
Contributor Author

commented May 31, 2019

@abadger As you say, I have test this again and again in my laboratory with different release version before i create this PR.
Also you can review the codes that I have commit.To find all, xpath should not include data root tag, otherwise only one element of data can be found, or none.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.